Closed Bug 1094745 Opened 10 years ago Closed 8 years ago

DOMWalker uses function.call to apply hooks on the DOM nodes being processed

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: cosmin-malutan, Unassigned, Mentored)

Details

(Whiteboard: [lang=js]) 

DOMWalker uses function.call to apply hooks on the DOM nodes being processed. This causes confusions in places where we use the DOMWalker API because this is not something that a consumer can assume or know.
So the hooks should have an argument, which would be the DOM node, and they should be called directly without call.

http://hg.mozilla.org/qa/mozmill-tests/file/907d141f2822/lib/dom-utils.js#l250
Mentor: hskupin
Whiteboard: [lang=js]
Mozmill tests are no longer in use. So closing this bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.