1095036 - Copy context menu stops working in Page Info

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: regression

Steps To Reproduce:
1. Open any page which contains images
   (e.g. https://bugzilla.mozilla.org/ )
2. Open Page Info and select Media tab
3. Attempt to copy an image url with right click context menu

Actual Results:
No thing copied.

The following error mesage is shown in Error Console:

Error: ReferenceError: gClipboardHelper is not defined
Source File: chrome://browser/content/pageinfo/pageInfo.js
Line: 1211


Expected Results:
Copy command should be performed succesfully without error.

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dc4a906df95
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141104134948
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a7f16c817b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141104140142
Pushlog;
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3dc4a906df95&tochange=a9a7f16c817b

Regressed by: Bug 611388

Comment 1

[Eric Faust [:efaust]]

Attachment: fixpageinfo.patch

Yeah, that's me. I took a look around for these, but apparently missed at least one.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8518360 [details] [diff] [review]
fixpageinfo.patch

Review of attachment 8518360 [details] [diff] [review]:
-----------------------------------------------------------------

A test to make sure this doesn't happen again would be good.

Comment 3

[Eric Faust [:efaust]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/763ae102275b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/763ae102275b

Comment 5

[pratyasmitamishra]

 Bugday-20141218 :Able to perform copy command successfully without error.