1095199 - Standardize on cb() vs callback()

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Peter deHaan [:pdehaan]]

Steps to reproduce:

$ egrep -nir "callback\(" . --exclude-dir={coverage,node_modules} | wc -l
     147

$ egrep -nir "cb\(" . --exclude-dir={coverage,node_modules} | wc -l
      62


Actual results:
callback(): 147 instances
cb():        62 instances


Expected results:
consistent use of `cb()` or `callback()` throughout code.

Comment 1

[Alexis Metaireau (:alexis)]

Yes, thanks. Preferred way is to use `callback` everywhere.

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

I just continue to use cb for async.map callbacks in redis backend since we already use callback for the method callbacks.

Comment 3

[Rémy Hubscher (:natim)]

see: egrep -nir "cb\(" . --exclude-dir={coverage,node_modules,loadtests}

Comment 4

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/54d9c07f27c22af7bc9d1fbe202667e5b1a7e865