Closed Bug 1095250 Opened 10 years ago Closed 10 years ago

Use integration branch sha for treeherder revision_hash

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

[PullReq] KevinGrandon:bug_1095250_alternate to KevinGrandon:master
50 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
Currently it looks like we're posting the same sha for re-triggered jobs, even after a failure/rebase. Instead I suppose we need to use the sha of the integration branch.

If we don't, we can end up with: https://treeherder.allizom.org/ui/#/jobs?repo=gaia-try&revision=e31b4373fef7dc04536df476e7c5650fb826dbd1

Probably need to update this: https://github.com/KevinGrandon/autolander/blob/master/lib/taskgraph.js#L108
Hmm, this might be wrong. When I try this it appears I get no tasks in the treeherder display.
Attachment #8518630 - Attachment is obsolete: true
Comment on attachment 8518665 [details] [review]
[PullReq] KevinGrandon:bug_1095250_alternate to KevinGrandon:master

I think this is better, but still not 100% right. Will figure out the right thing tomorrow.
Attachment #8518665 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: