Closed
Bug 1096737
Opened 10 years ago
Closed 10 years ago
[Settings] All unit tests of settings app are not running
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: eragonj)
References
Details
Attachments
(1 file)
The issue was regressed by bug 1092934. The paths of the unit test files of the original settings app were overwritten by the ones of the settings app of tv.
Assignee | ||
Comment 1•10 years ago
|
||
Discussed with John Hu, Arthur and Ricky about this bug. In order not to block current development, we decided to rename "tv/settings -> tv/smart-settings" first to make unit tests runnable and will file another follow-up bugs for test agent.
Assignee: nobody → ejchen
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8520389 [details] [review] patch on master @Dwi, can you help me review this patch ? thanks ! @Ricky, @Arthur and @John, need your feedbacks for this change, too !
Attachment #8520389 -
Flags: review?(tzhuang)
Attachment #8520389 -
Flags: feedback?(ricky060709)
Attachment #8520389 -
Flags: feedback?(im)
Attachment #8520389 -
Flags: feedback?(arthur.chen)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8520389 [details] [review] patch on master Looks good!
Attachment #8520389 -
Flags: feedback?(arthur.chen) → feedback+
Comment 5•10 years ago
|
||
Comment on attachment 8520389 [details] [review] patch on master Looks good to me, Thanks!
Attachment #8520389 -
Flags: review?(tzhuang) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8520389 [details] [review] patch on master LGTM. thanks
Attachment #8520389 -
Flags: feedback?(ricky060709) → feedback+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8520389 [details] [review] patch on master Thanks all, merged into Gaia/master (2.2) : https://github.com/mozilla-b2g/gaia/commit/6af3a8a833eb8bb651e8b188cb3f3c3a43bb4184
Attachment #8520389 -
Flags: feedback?(im)
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•