1096921 - Typo in CategoryManagerInterposition.methods.deleteCategoryEntry.

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Tooru Fujisawa [:arai]]

http://hg.mozilla.org/mozilla-central/file/5e4af5123dc9/toolkit/components/addoncompat/RemoteAddonsParent.jsm#l176
> CategoryManagerInterposition.methods.deleteCategoryEntry =
>   function(addon, target, category, entry, persist) {
>     if (category == "content-policy") {
>       ContentPolicyParent.remoteContentPolicy(entry);
>     }

remoteContentPolicy should be removeContentPolicy, right?

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Fix typo in CategoryManagerInterposition.methods.deleteCategoryEntry.

Try in running: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fa8c5a4c81b6

Comment 2

[Tooru Fujisawa [:arai]]

Try run is green :)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8520602 [details] [diff] [review]
Fix typo in CategoryManagerInterposition.methods.deleteCategoryEntry.

Review of attachment 8520602 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, definitely! Thanks for spotting that!

Comment 4

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/1e768cb2fa3f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e768cb2fa3f