Closed Bug 1097686 Opened 10 years ago Closed 10 years ago

Show subject if exists in the outgoing/incoming call

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

Attachments

(5 files)

Github pull request
204 bytes, text/html
borjasalguero
: review+
Details
subject_call_screen_1.jpeg
67.55 KB, image/jpeg
Pau
: ui-review-
Details
subject_call_screen_2.jpeg
308.76 KB, image/jpeg
Details
subject_call_screen_3.jpeg
64.23 KB, image/jpeg
Details
subject_call_screen_4.jpeg
97.26 KB, image/jpeg
Details
Blocks: 1097529
Depends on: 1097691
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Summary: Show subject if exists in the outgoing call → Show subject if exists in the outgoing/incoming call
Attached file Github pull request — 

        Attachment #8532066 -
        Flags: review?(borja.bugzilla)

    
    

    
  


  

        Attachment #8532067 -
        Flags: ui-review?(b.pmm)

    
    

    
  


  

        Attachment #8532068 -
        Flags: ui-review?(b.pmm)

    
    

    
  


  

        Attachment #8532069 -
        Flags: ui-review?(b.pmm)

    
    

    
  


  

        Attachment #8532070 -
        Flags: ui-review?(b.pmm)

    
    

    
  
As Pau in on PTO and we are really in a hurry to land everything in the next two weeks, Monica can you have a look at the ui-reviews requested by Cristian to Pau. 

If later Pau finds any issue, we can address it in a follow-up bug
Flags: needinfo?(monica.meika)

    
    

    
  
Comment on attachment 8532066 [details]
Github pull request

Great job Cristian! Small nits and ready to go! Thanks!

        Attachment #8532066 -
        Flags: review?(borja.bugzilla) → review+

    
    

    
  
Thanks Borja, comments addressed

    
    

    
  
As we explained to Monica offline, the gradient behind name and subject is not feasible because of performance (gradient + video). It was studied at the beginning of the project and it was removed from designs for that reason. Landing it as Maria Angeles suggested and we will address comments/changes like sizes, colors, etc.. if Pau see something wrong.

In master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ffa96980a67192622546234a950d6002074ebc42
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8532067 [details]
subject_call_screen_1.jpeg

I believe the subject is in the "light" version of the font and it should be in the "regular" one. Same font style.

        Attachment #8532067 -
        Flags: ui-review?(b.pmm) → ui-review-

    
  
Blocks: 1109067

    
    

    
  
Comment on attachment 8532068 [details]
subject_call_screen_2.jpeg

same issue

        Attachment #8532068 -
        Flags: ui-review?(b.pmm)

    
    

    
  
Comment on attachment 8532069 [details]
subject_call_screen_3.jpeg

same issue

        Attachment #8532069 -
        Flags: ui-review?(b.pmm)

    
    

    
  
Comment on attachment 8532070 [details]
subject_call_screen_4.jpeg

same issue

        Attachment #8532070 -
        Flags: ui-review?(b.pmm)
Flags: needinfo?(monica.meika)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: