1097736 - Can't assign reviewers to a review request

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[James Graham [:jgraham]]

Trying to type in the reviewer names for a commit, I get a js error, but no dropdown:

15:17 < jgraham> TypeError: s is undefined
15:17 < jgraham> return r.indexOf(e) === 0 ? i.indexOf(e) === 0 ? r.localeCompare(i)  : - 1 : i.indexOf(e) === 0 ? 1 : s.localeCompare(o)
15:18 < jgraham> It appears that s.data.fullname doesn't exist

This is also broken in Chrome. AFAICT I can't create a review request at all until this works.

Comment 1

[Gregory Szorc [:gps]]

Thank you for filing and for taking the time to report the JS error.

To help us reproduce, what string did you type in the box? Can you start a JS debugger and see what entry Review Board is barfing on?

Comment 2

[James Graham [:jgraham]]

It doesn't really matter what I type in the box e.g. "gps" reproduces the above behaviour.

The debugger output is in the summary. It comes from commits.min.whatever.js, line 173 of the prettified source.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I think I know what's going on here.

We've got code in commits.js that is doing comparisons on both usernames and fullnames in order to create the sorted autocomplete list.

For profiles that are private, users that do not have staff / admin privileges to retrieve their email addresses or full names via the API.

I believe we need to alter commits.js to take into account the possibility of fullnames not being available in the result that is returned from the server.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: bz://1097736/mconley

Comment 5

[Mike Conley (:mconley) (:⚙️)]

/r/505 - Bug 1097736 - rbmozui: Can't assign reviewers to a review request. r=?

Pull down this commit:

hg pull review -r b72134811c6be795a5e53dd6f75dcaf816090fc7

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/503/#review215

Hang on, I've got a better solution here.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

/r/505 - Bug 1097736 - rbmozui: Can't assign reviewers to a review request. r=?

Pull down this commit:

hg pull review -r 824f15e433125ed4e07dccf2add386640947fdb7

Comment 8

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/503/#review223

Ship It!

Comment 9

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/d104b9116891

Comment 10

[Mike Conley (:mconley) (:⚙️)]

This fix has been pushed to production. Can you confirm the fix on your end, jgraham?

Comment 11

[James Graham [:jgraham]]

Yep, this is working now. Thanks!

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1097736 - rbmozui: Can't assign reviewers to a review request. r=?