Closed
Bug 1097785
Opened 10 years ago
Closed 9 years ago
Legal-docs-based pages should not rely on active tags in .lang files
Categories
(www.mozilla.org :: Bedrock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmac, Assigned: kohei)
References
(Blocks 1 open bug)
Details
(Whiteboard: [kb=1611395] )
Attachments
(1 file)
Currently we're having to manage the active languages for the privacy policies etc. (under https://www.mozilla.org/privacy/) with "active" tags in .lang files for the templates. But really we should be activating these locales based on which language versions of the docs are available in the legal-docs repo. It's possible we're happy with having more control over which languages are active, in which case we can WONTFIX this. But allowing the legal-docs authors to control this seems most appropriate.
Comment 1•10 years ago
|
||
I'm meeting with Peiying on Monday to discuss. More after that. Thx.
Assignee | ||
Comment 2•10 years ago
|
||
WIP: https://github.com/kyoshino/bedrock/compare/bug-1097785-legal-docs-lang
Assignee | ||
Updated•10 years ago
|
Blocks: bedrock-l10n
Comment 3•10 years ago
|
||
Let's move forward with Kohei's fix to allow Legal-docs authors to have more control. Kohei - when it is ready, will you let me know what legal-docs authors will need to change in their process?
Updated•10 years ago
|
Whiteboard: [kb=1611395]
Assignee | ||
Comment 4•10 years ago
|
||
I'll finalize my pull request this week. The remaining issue is the page's language switcher. Once my PR is landed, locales will be automatically activated once localized legal-docs are merged to Bedrock, without any extra steps by the authors :)
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Component: Pages & Content → Bedrock
Assignee | ||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/095784321ba756d71157ced2cc0f8191c472ef85 Fix Bug 1097785 - Legal-docs-based pages should not rely on active tags in .lang files https://github.com/mozilla/bedrock/commit/75db96a7a25f36471116fec9ea89e56f2cd065a3 Merge pull request #2644 from kyoshino/bug-1097785-legal-docs-lang Fix Bug 1097785 - Legal-docs-based pages should not rely on active tags in .lang files
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 7•9 years ago
|
||
Files removed from trunk in r137536, also taking the chance to make /privacy properly localizable. Moved to stage in r137543 (together with other changes), waiting to test on www.allizom.org
Assignee | ||
Comment 8•9 years ago
|
||
Thanks :flod!
You need to log in
before you can comment on or make changes to this bug.
Description
•