1098124 - Rearrange keyboard settings page scripts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The current keyboard settings page contains a few settings and scripts are not arranged in a way that could care each other. We will hit bugs like the page being wrongly closed by one section while the other section is downloading. I am therefore working on rearranging the script for it to follow the constructor pattern.

All features touching the settings panel is probably depend on this bug.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#26106

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8522140 [details] [review]
mozilla-b2g:master PR#26106

This patch is ready for review.

-- The UI toggles are now backed by Settings modules in js/keyboard/settings.js just like the main app.
-- These settings are represented in the UI as SettingsView.
-- Each sections has it's group view.
-- When one toggles settings we will disable and re-enable the toggle. The requests are queued in a promise chain.
-- a CloseLockManager manages each of the settings async operations so we don't close the frame in the middle of the flight. This is also important for the future downloadable and user dictionary features.
-- everything is started with KeyboardSettingsApp.

John, given the fact you will be working on user dictionary UIs, please take a look and make sure it fits the use cases. Thanks.

Comment 3

[howie [:howie]]

This also covers the RTL work for keyboard setting page.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to howie [:howie] from comment #3)
> This also covers the RTL work for keyboard setting page.

I can verify the Keyboard Settings page looks fine in RTL language. This bug still blocks other 2.2 works though.

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8522140 [details] [review]
mozilla-b2g:master PR#26106

I love the design of CloseLocks !

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8522140 [details] [review]
mozilla-b2g:master PR#26106

Looks good to me as well, only some typos.
Thanks a lot!

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/3ca836100a2c4cc2e45923f3ff0a39ede44d9507

Comment 8

[Francesco Lodolo [:flod]]

Can someone explain how I reach these 3 new strings, and also what "handwriting" actually does?

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Francesco Lodolo [:flod] from comment #8)
> Can someone explain how I reach these 3 new strings, and also what
> "handwriting" actually does?

:flod, you would need to build the phone with |zh-Hans-Handwriting| layout enabled. Noted that due to bug 1098188 label will not show up unless it's not the default language.

For the feature (and screenshot), see bug 1020847.

Comment 10

[howie [:howie]]

Remove the feature b2g tag to match the new v2.2 scope.