1098150 - Add a panel for basic mathematical constructions

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Frédéric Wang (:fredw)]

Follow-up of bug 1077291. We should add another panel to enter basic mathematical constructions like "\frac{}{}", "\sqrt{}", etc

Comment 1

[Raniere Silva]

Is the product and component correct? Should it be SeaMonkey and Composer?

Comment 2

[Frédéric Wang (:fredw)]

Yes, sorry.

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Patch V1

Here is a first patch showing the idea. I'm not exactly sure about the important constructions we want to present and how we will organize them (it's possible that we want several tabs).

Comment 4

[[e-mail]]

Comment on attachment 8536006 [details] [diff] [review]
Patch V1

I don't think the table ones work in the same tab as the others.

You might want to select the result of applying a unary function  e.g. applying the boxed effect and then the slashed effect to the result.

Comment 5

[Frédéric Wang (:fredw)]

Attachment: Patch V2

This addresses the two previous remarks.

There is one minor problem with the custom insertion code of insertLaTeXCommand: Undo/Redo does not work well. I tried a beginTransaction/endTransaction on input.editor but that did not help.

Comment 6

[Frédéric Wang (:fredw)]

@neil: any update on this?

Comment 7

[[e-mail]]

Comment on attachment 8560882 [details] [diff] [review]
Patch V2

I probably got snowed under a flurry of requests or something, and it's just taken me far too long to work through them and think about catching up on some of my older requests. Sorry about that.

>+  // For a single math symbol, just use the insertText command.
>+  if (aButton.label) {
>+    gDialog.input.editor.QueryInterface(Components.interfaces.nsIPlaintextEditor).insertText(aButton.label);
>+    return;
>+  }
...

(In reply to Frédéric Wang from comment #5)
> There is one minor problem with the custom insertion code of
> insertLaTeXCommand: Undo/Redo does not work well. I tried a
> beginTransaction/endTransaction on input.editor but that did not help.
...

>+  // Update the input text and selection.
>+  gDialog.input.value =
>+    gDialog.input.value.substring(0, selectionStart) + latex +
>+    gDialog.input.value.substring(selectionEnd);
If you insertText(latex) instead (as per the first snippet) then that should just work.

>+  gDialog.input.selectionStart = selectionStart + latexNewStart;
>+  gDialog.input.selectionEnd = selectionStart + latexNewEnd;
Prefer .setSelectionRange()

Comment 8

[Frédéric Wang (:fredw)]

Attachment: Patch V3

Thanks, that indeed seems to solve the undo/redo issue.

Comment 9

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/bb21f194420c

Comment 10

[Rainer Bielefeld]

Attachment: screenshot insert LaTeX math

We are talking about the 2 most left new TABs?

Comment 11

[Frédéric Wang (:fredw)]

Yes, these tabs insert "complex" LaTeX constructions while the others insert only a single unicode character.