1098338 - Unable to save an image from a webpage

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Viorela Ioia [:viorela]]

Tapping the Save button to save an image from a webpage has no effect, the image is not saved to Galery. 

#STR:
1. Launch Browser
2. Go to a webpage where there's a picture available (E.g: http://mozqa.com/data/firefox/images/mozilla_logo.jpg)  or go to www.google.com -> images, then in the search field type something to find any picture
3. Long tap on the image
4. Tap Save image

Expected results:
'Download complete' message appears, the image is saved to Gallery

Actual results:
There's no message displayed, the image is not saved to Gallery

The issue is reproducible manually, and also by running the automated test (test_browser_save_image.py)
Reproduction rate: 5/5
The issue is not reproducible on v2.1 

Regression rate, based on b2g-inbound:
Last working build:
Gaia-Rev        c1f97d511b199998ce002d1c2c1fa78435687141
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/e203b87d8ce3
Build-ID        20141112031313
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141112.063653
FW-Date         Wed Nov 12 06:37:05 EST 2014
Bootloader      L1TC10011880

First failing build:
Gaia-Rev        c1f97d511b199998ce002d1c2c1fa78435687141
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/b1a6ecfca674
Build-ID        20141112032814
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141112.070025
FW-Date         Wed Nov 12 07:00:35 EST 2014
Bootloader      L1TC10011880\

No Gaia changes

Gecko pushlog: https://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=e203b87d8ce3&tochange=b1a6ecfca674


Jenkins report: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.ui.functional.non-smoke/116/HTML_Report/

Comment 1

[Viorela Ioia [:viorela]]

Attachment: logcat

logcat of the issue

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Viorela Ioia [:viorela] from comment #1)
> Created attachment 8522233 [details]
> logcat
> 
> logcat of the issue

Should be fixed.

See also bug 1098118 and bug 1098145

Comment 3

[Viorela Ioia [:viorela]]

This issue is not fixed, I flashed my device with the latest b2g-inbound build and I was still able to reproduce STR from comment 0. 

Gaia-Rev        41e4efdf00262d54a653fda21eac30f5554ac137
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/be0a8f9b3939
Build-ID        20141113214222
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141114.005910
FW-Date         Fri Nov 14 00:59:24 EST 2014
Bootloader      L1TC10011880

Kan-Ru, can you please take a look again? Thanks!

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Confirmed it's not working.

W/GeckoConsole(15324): [JavaScript Error: "TypeError: 'download' called on an object that does not implement interface HTMLIFrameElement." {file: "app://system.gaiamobile.org/js/browser_context_menu.js" line: 146}]

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/26138

Comment 6

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/fb64ecaf2a840b482b2153c27f8ebe187e2e1d47