1098521 - make deployment process easier, more robust

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P3)

Description

[Kendall Libby [:fubar] (he/him)]

current deploy process is less than ideal, using webops' deploy stuff. also, it doesn't handle v-c-t. it should also drain/undrain the web heads for restarting httpd, similar to what BMO does.

:gps likely has other, probably better, ideas.

Comment 1

[Steven MacLeod [:smacleod]]

Something we also should probably consider when deploying is blocking pushes to the review repos and letting in progress pushes complete.

The part of the system talking to Review Board during the push makes many requests - if Review Board goes down mid push it will be left in a partial state. The user *should* be able to discard the broken state, or just push overtop of it, but I'm not 100% sure that will cover all possible cases. We should at least investigate this.

Comment 2

[Gregory Szorc [:gps]]

We can easily have a hook on the Mercurial server that looks for the presence (or lack thereof) of a heartbeat file and deny all push actions until the check passes.

Comment 3

[Mark Côté [:mcote]]

You did work on this recently, right?  What did you do, and what else should we do?

Comment 4

[Gregory Szorc [:gps]]

No, we still need to invest in this.

This overlaps strongly with work inside v-c-t for configuring the testing environment. I'll find time to talk to fubar sometime about making this all suck less.

Comment 5

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.