109860 - Switch default optimisation to -xO4 for Sun Workshop builds

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement, P5)

Description

[Roland Mainz]

RFE: Switch default optimisation for Sun Workshop builds to -xO4.

I have tested some Sun Workshop 6U2 build the last two weeks... looks stable for
me...

Comment 1

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 2

[Roland Mainz]

cls:
Can we run the "nebiros"-tinderbox some days with -xO4 and look if it causes any
problems ?

Comment 3

[hacker formerly known as [e-mail]]

Flipped.  We should state our minimum recommended version of Forte somewhere. 
Right now I'm leaning towards 6U2 if only because it's the only version that
we've regularly built with for some time now.

Comment 4

[Roland Mainz]

Christopher Seawood wrote:
> Flipped.

Where ? I can't see the change in configure.in ... ;-(

Comment 5

[hacker formerly known as [e-mail]]

"Flipped" referred to the suggestion of putting it on nebiros.  I don't plan on
checking it into configure.in until we have a minimum stated version of Forte
that we support so that when things start breaking with older versions (ie,
WS5), we can mark those as unsupported.

Comment 6

[Roland Mainz]

cls:
I am not sure but I guess WS5 was EOL'ed some time ago... can anyone confirm
this (petez?) ?

Current WS6U2 compiles with -xO4 and -xO5 without problems, IMHO we should make
this the minimum Forte release we support.

Comment 7

[Roland Mainz]

nidheesh:
1. What's the mimimum Workshop version supported by Sun ?
2. What do you think about bumping the default optimisation to -xO4 ?

Comment 8

[Nidheesh Dubey]

I agree that Forte 6U2 with -xO5 is best. Sun build it's Solaris netscape using
F6U1 due to common build environment restrictions for Solaris 9. With F6U1 -xO5
works fine with sparc but needed a patch to build on solaris/intel. As long as
you have these patches I feel safe that one can use -x05 with even F6U1.

I am not sure if this patch is needed for F6U2. We have had test builds that
worked fine with F6U2 with -xO5 on sparc. I am not sure if U2 requires any patch
for intel builds. Once it is verified I think U2 with -xO5 is right way to go. 

Added Kevin Lee from Sun RE. He knows the exact patches used by Sun releases.

Comment 9

[Roland Mainz]

Attachment: Patch for 2002-08-18-08-trunk to switch default optimisation from -O to -xO4

Comment 10

[hacker formerly known as [e-mail]]

Comment on attachment 96509 [details] [diff] [review]
Patch for 2002-08-18-08-trunk to switch default optimisation from -O to -xO4

r=cls

Comment 11

[hacker formerly known as [e-mail]]

Patch has been checked in.