Closed
Bug 1099046
Opened 10 years ago
Closed 9 years ago
Autocomplete popup displays "moz-action:searchengine,..." for keyword searches while pressing Shift
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
People
(Reporter: dao, Assigned: Unfocused)
References
Details
Attachments
(1 file, 1 obsolete file)
7.24 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
STR: - add a keyword for a search engine - type the keyword plus some search term in the location bar - hit the down arrow key to select the autocomplete item for the keyword search - press Shift
Reporter | ||
Updated•10 years ago
|
Summary: Autocomplete popup displays moz-action:searchengine,... for keyword searches while pressing Shift → Autocomplete popup displays "moz-action:searchengine,..." for keyword searches while pressing Shift
Assignee | ||
Comment 2•10 years ago
|
||
Not fixed by bug 1070778, so taking this now since it's enough to block shipping unifiedcomplete.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
No longer depends on: 1070778
Flags: qe-verify-
Flags: firefox-backlog+
Comment 3•10 years ago
|
||
Hi Blair, can you provide a point value.
Iteration: --- → 36.3
Flags: needinfo?(bmcbride)
Updated•10 years ago
|
Iteration: 36.3 → 37.1
Assignee | ||
Comment 5•10 years ago
|
||
Dependent on the changes in head.js done in bug 1073339.
Attachment #8529396 -
Flags: review?(mak77)
Comment 6•10 years ago
|
||
Comment on attachment 8529396 [details] [diff] [review] Patch v1 Review of attachment 8529396 [details] [diff] [review]: ----------------------------------------------------------------- I'm not sure why but it doesn't seem to work for me, I tried a couple rebuilds but nothing.. when I move to a switch to tab entry and I press shift, the switch to tab text should be replaced by the url but that doesn't happen.
Attachment #8529396 -
Flags: review?(mak77)
Assignee | ||
Comment 7•10 years ago
|
||
Could you try again? autocomplete.xml got bitrotten, am wondering if that was your issue. This patch is the same as the previous, just rebased.
Attachment #8529396 -
Attachment is obsolete: true
Attachment #8530821 -
Flags: review?(mak77)
Comment 8•10 years ago
|
||
Comment on attachment 8530821 [details] [diff] [review] Patch v1.1 Review of attachment 8530821 [details] [diff] [review]: ----------------------------------------------------------------- yeah now it works. sorry for the delay. ::: toolkit/content/widgets/autocomplete.xml @@ +1608,5 @@ > this.setAttribute("actiontype", action.type); > > if (action.type == "switchtab") { > + this.classList.add("overridable-action"); > + displayUrl = action.params.url; splinter doesn't show the right indentation here, please check.
Attachment #8530821 -
Flags: review?(mak77) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [blocked on bug 1073339 landing]
Updated•10 years ago
|
Iteration: 37.1 → 37.2
Updated•10 years ago
|
Whiteboard: [blocked on bug 1073339 landing]
Updated•10 years ago
|
Iteration: 37.2 → 37.3
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f9d665c7c667
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f9d665c7c667
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Comment 11•8 years ago
|
||
This bug affects me on Firefox 48 for Linux.
Comment 12•8 years ago
|
||
(for all keyword completions, not just when shift is pressed)
Comment 13•8 years ago
|
||
(In reply to Hide my Email from comment #11) > This bug affects me on Firefox 48 for Linux. please check in Safe mode, cause your issue may be caused by an add-on. https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode
Comment 14•8 years ago
|
||
Ah, it's not exactly fault of an extension but some internal change of Firefox that broke keyword previews when the bookmark URL starts with a pseudo-protocol like private: . I'm waiting for the new version of Private Tab to be reviewed to test if this still happens (https://addons.mozilla.org/firefox/addon/private-tab/versions/).
You need to log in
before you can comment on or make changes to this bug.
Description
•