1101083 - js_DumpBacktrace should dump all frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: dump-backtrace

It looks like DumpJSStack already does this. However, that function doesn't accept an arbitrary context and it also segfaults when we're using CPOWs (since it tries to call toString on them, which does an IPC).

Comment 1

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8524757 [details] [diff] [review]
dump-backtrace

Review of attachment 8524757 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me.

Comment 2

[Boris Zbarsky [:bzbarsky]]

We should fix the crash bit, at least.  DumpJSStack is a very commonly used tool in debugging Firefox, and having it randomly explode is not so great.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d99caaf9ab8c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d99caaf9ab8c