1101261 - Visiting www.mozilla.org/firefox/new/ (and others) with an es browser leads to /es-AR/ page.

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Chris More [:cmore]]

Mike Connor alerted us to a possible bug that we need to dig in to.

He was using Chrome with his accept_lang as:

es,en-GB;q=0.8,en;q=0.6,en-US;q=0.4

When he visited https://www.mozilla.org/firefox/new/

He was presented with https://www.mozilla.org/es-AR/firefox/new/.

The expected result should be https://www.mozilla.org/es-ES/firefox/new/.

I also checked Google Analytics and if I look at people who visit /es-AR/firefox/new/, 50% of them are running the "es" language. 

I am able to replicate this bug, but only on /firefox/new/.

If I set my Chrome browser to "spanish - espanol" and visit:

https://www.mozilla.org/ it redirects to https://www.mozilla.org/es-ES/ as expected.

If I visit https://www.mozilla.org/firefox/new/ it redirects to https://www.mozilla.org/es-AR/firefox/new/

Why is the locale detection on www.mozilla.org homepage correctly giving the user es-ES content, but the /firefox/new/, /firefox/partners/, /firefox/desktop/, giving es-AR for the "es" language? It seems that the homepage is the only page correctly giving es-ES when the accept_lang is "es".

Comment 1

[Chris More [:cmore]]

I have also confirmed that setting Firefox as "es" also presents es-AR to all non-homepage requests.

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: pull request for funfactory

The same applies to "en" that should be redirected to "en-US" instead of "en-GB". This PR solve both cases.

Comment 3

[Francesco Lodolo [:flod]]

Part of this was definitely covered in bug 774675
https://github.com/mozilla/bedrock/blob/master/etc/httpd/global.conf#L10-L12

But I confirm the issue with 'es'->'es-AR' on all pages but the home.

Comment 4

[Mike Connor [:mconnor]]

Given the global.conf bit, do we need to adjust behaviour of pt?

Comment 5

[Kohei Yoshino [:kohei]]

I'll map pt to pt-BR.

Comment 6

[Chris More [:cmore]]

Would we consider mapping/redirecting es-419 to es-ES? es-419 is a growing language and we don't have that currently mapped to anything. It is supposed to represent Latin America and the Caribbean languages and es-ES is probably the most generic. Any other suggestions on what to do with es-419?

Comment 7

[Paul [:pmac] McLanahan]

The current PR from Kohei will redirect any es-* that we don't explicitly support to es-ES. So until we have something else that we'd like to do with es-419, at least they'll get the default.

es-419 seems odd to begin with since my understanding is that there is a fairly wide difference between many LATAM Spanish dialects. So having a single locale for them all sounds troublesome at best. Though redirecting a specifically LATAM locale to Spain-Spanish also seems odd.

/me shrugs

Comment 8

[Kohei Yoshino [:kohei]]

Attachment: pull request for bedrock

Yes, I have just tested my PR locally with Accept-Language: es-419, and /firefox/new/ redirected me to /es-ES/firefox/new/.

Comment 9

[Chris More [:cmore]]

(In reply to Paul McLanahan [:pmac] from comment #7)
> The current PR from Kohei will redirect any es-* that we don't explicitly
> support to es-ES. So until we have something else that we'd like to do with
> es-419, at least they'll get the default.
> 
> es-419 seems odd to begin with since my understanding is that there is a
> fairly wide difference between many LATAM Spanish dialects. So having a
> single locale for them all sounds troublesome at best. Though redirecting a
> specifically LATAM locale to Spain-Spanish also seems odd.
> 
> /me shrugs

Yeah, es-419 is more of a location than a specific language and we really don't have location pages on mozilla.org. Let me check to see what language most es-419 people download. Hang on.

Comment 10

[Chris More [:cmore]]

For es-419 visitor downloads, 43% download es-ES, 24% es-MX, 14% es-AR, 5% es-CL.

As for es-419 visitor countries, 25% is Mexico, 15% is Ecuador, 13% Argentina, 11% Columbia.

You could argue that es-419 should default to es-MX with these numbers, but still it is not 100% ideal for everyone.

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c824cb26bca9aa69ed26ba87844ce416ac556140
Fix Bug 1101261 - Visiting www.mozilla.org/firefox/new/ (and others) with an es browser leads to /es-AR/ page.

https://github.com/mozilla/bedrock/commit/d1403eac5ba5df9d6e63018f9d0a85ee46c149b5
Merge pull request #2520 from kyoshino/bug-1101261-es-locale

Fix Bug 1101261 - Visiting www.mozilla.org/firefox/new/ (and others) with an es browser leads to /es-AR/ page.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://www-dev.allizom.org/firefox/new with [es] as my 1st locale/language -- I get redirected to https://www-dev.allizom.org/es-ES/firefox/new/

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

And Verified FIXED on prod, too.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screen Shot 2014-11-21 at 4.21.13 PM.png

Comment 16

[Paul [:pmac] McLanahan]

:stephend, does that trans bar behavior indicate a bug? Looks like it's asking if you want to view in English when you had your browser set to "es".

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Paul McLanahan [:pmac] from comment #16)
> :stephend, does that trans bar behavior indicate a bug? Looks like it's
> asking if you want to view in English when you had your browser set to "es".

Could be; I also had "en-US" and "en" in my "Languages"/accept-language header -- I'll confirm with Felipe from the Firefox Desktop team.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Stephen Donner [:stephend] from comment #17)
> (In reply to Paul McLanahan [:pmac] from comment #16)
> > :stephend, does that trans bar behavior indicate a bug? Looks like it's
> > asking if you want to view in English when you had your browser set to "es".
> 
> Could be; I also had "en-US" and "en" in my "Languages"/accept-language
> header -- I'll confirm with Felipe from the Firefox Desktop team.

Sorry, Felipe -- I meant to ping you on IRC, but keep forgetting; mind weighing in, here?  Thanks!

Comment 19

[:Felipe Gomes (needinfo for replies!)]

Hey Stephen, that bar on the screenshot is not part of the front-end translation feature. That bar is in the webpage, which offers to change the language by itself.

So while it's likely a bug, it's part of the website code, which I don't know much about