Closed
Bug 1101537
Opened 10 years ago
Closed 10 years ago
[RTL] list item and headers are not aligned properly in RTL
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S9 (21Nov)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | verified |
People
(Reporter: hub, Assigned: hub)
References
Details
Attachments
(2 files)
In Arabic (RTL), the letter of the header should be aligned to the left. And the line is too short.
Assignee | ||
Comment 1•10 years ago
|
||
I mean the letter should be aligned to the right. Like the text. Which is ignoring the margin. It seems to be all related.
Assignee | ||
Comment 2•10 years ago
|
||
Bug 1074546 is part of why.
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Summary: [RTL] list item headers are not aligned properly in RTL → [RTL] list item and headers are not aligned properly in RTL
Assignee | ||
Comment 3•10 years ago
|
||
David, if you think somebody else should review, let me know.
Attachment #8525349 -
Flags: review?(dflanagan)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8525349 [details] [review] Link to pull request Jim, can you?
Attachment #8525349 -
Flags: review?(dflanagan) → review?(squibblyflabbetydoo)
Comment 5•10 years ago
|
||
Comment on attachment 8525349 [details] [review] Link to pull request See my comments on GitHub. It's a lot easier to use -moz-margin-start and -moz-margin-end, (likewise for padding) and those are explicitly recommended for RTL support in FxOS.
Attachment #8525349 -
Flags: review?(squibblyflabbetydoo) → review-
Assignee | ||
Comment 6•10 years ago
|
||
Actually I disagree. Will comment locally and explain why.
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8525349 [details] [review] Link to pull request Updated the Pull Request with the feedback. Thanks.
Attachment #8525349 -
Flags: review- → review?(squibblyflabbetydoo)
Comment 8•10 years ago
|
||
Comment on attachment 8525349 [details] [review] Link to pull request Looks good, aside from one small nit on GitHub. And good catch with the -moz-margin-start stuff! (Note that I didn't actually flash this patch, but it's simple enough that I don't think anything will *break*.)
Attachment #8525349 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Merged https://github.com/mozilla-b2g/gaia/commit/4431afd37155995eace2ca377d82ccbd3378633c
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
Comment 10•9 years ago
|
||
Hey Hubert Please provice reproduce step to tester for verification.Thanks!
Flags: needinfo?(hub)
Comment 11•9 years ago
|
||
I examine the list item and headers of Playlist Artists Ablums and Songs view in Music,it seems that the letter of the header is aligned to the left. I thinks this issue is verified successfully on Flame 2.2: Gaia-Rev f5b3d1b6cfa3e702033f613915ae637cb735cbfb Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6 Build-ID 20150119002502 Version 37.0a2 Device-Name flame FW-Release 4.4.2 Hi Hubert, I have recorded test steps,refer to video VIDEO0265.mp4.Please confirm that my test steps are correct.
Comment 12•9 years ago
|
||
Comment 15•9 years ago
|
||
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15196/
You need to log in
before you can comment on or make changes to this bug.
Description
•