Closed
Bug 1101539
Opened 10 years ago
Closed 10 years ago
Make Marionette's GeckoInstance actually support passing a nonstandard port
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: ted, Assigned: ted)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.22 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Passing a nonstandard port to Marionette doesn't work right now when you ask Marionette to launch the process for you, as GeckoInstance doesn't set the port pref using the passed-in port. (That wound up a lot more alliterative than I expected.) This simple patch fixes this issue.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8525321 -
Flags: review?(jgriffin)
Comment 2•10 years ago
|
||
Comment on attachment 8525321 [details] [diff] [review] Make Marionette's GeckoInstance actually support passing a nonstandard port Review of attachment 8525321 [details] [diff] [review]: ----------------------------------------------------------------- heh, thanks!
Attachment #8525321 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/76feeccb28cf
Assignee | ||
Updated•10 years ago
|
Blocks: luciddream
https://hg.mozilla.org/mozilla-central/rev/76feeccb28cf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•