1101565 - [FFOS] Some functions (like Input) in MediaCodecProxy lack mutex lock

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Blake Wu [:bwu][:blakewu]]

As bug 1094614 comment 8 and 11 pointed out, we need to add lock to avoid mCodec being changed while being checked.

Comment 1

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1101565-Add-locks-when-reading-mCodec.patch

Add locks when reading mCodec in MediaCodecProxy.cpp

Comment 2

[Blake Wu [:bwu][:blakewu]]

(In reply to Blake Wu [:bwu][:blakewu] from comment #1)
> Created attachment 8551205 [details] [diff] [review]
> Bug-1101565-Add-locks-when-reading-mCodec.patch
> 
> Add locks when reading mCodec in MediaCodecProxy.cpp
To be more clear,
Add locks to those functions which read/check mCodec.

Comment 3

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1101565-Add-locks-when-reading-mCodec-Final.patch

Carry r+ from sotaro.

Comment 4

[Blake Wu [:bwu][:blakewu]]

Building results look good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aceecc196d9
No need to run test cases since the pref is not enabled yet.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/147d4f71335e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/147d4f71335e