1101601 - Double-clicking a line should work to add a review comment

Status: RESOLVED FIXED

(MozReview Graveyard :: General, enhancement, P1)

Description

[(not currently active) Ted Mielczarek]

Right now you have to click on the line number to add a review comment. I'm used to being able to double-click on a line itself to add a comment (this works in Splinter and Rietveld). It would be nice if this worked in ReviewBoard as well.

Comment 1

[Gregory Szorc [:gps]]

This should be filed upstream. https://code.google.com/p/reviewboard/issues/list

Comment 2

[Mark Côté [:mcote]]

Fixed in core 2.5, which is almost in beta.  WONTFIXing it as part of MozReview specifically.

Comment 5

[Mark Côté [:mcote]]

Actually, I'll leave this open until it's in our deployment.

Comment 9

[Dan Minor [:dminor]]

It looks like mconley's fix in core is going to be backed out [1]. We'll need to work his patch [2] into the mozreview extension instead.

[1] https://hellosplat.com/s/beanbag/tickets/4018/
[2] https://reviews.reviewboard.org/r/6881/diff/3#index_header

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio

mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio

Comment 11

[Mauro Doglio [:mdoglio]]

Comment on attachment 8690617 [details]
MozReview Request: mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio

https://reviewboard.mozilla.org/r/25891/#review23317

This is simply awesome!

Comment 12

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/7014000ff305

Comment 13

[Mark Côté [:mcote]]

This is live on production now.

Comment 14

[Boris Zbarsky [:bzbarsky]]

For what it's worth, the behavior this introduced is probably the #1 thing making mozreview painful to use for me today... :(

Comment 15

[Mike Conley (:mconley) (:⚙️)]

This feature has been backed out and turned into a browser extension instead:

https://addons.mozilla.org/en-US/firefox/addon/rb-doubleclick/