1101762 - RSS Icon in url bar add-on caches and overwrites toolbar customizations

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect)

Description

[Michael Cooper [:mythmon]]

In particular, using "Rss Icon in url bar" [0] causes some kinds of customizations to the toolbar to be reverted or modified.

It seems that something triggered a "Save state", and then whenever the browser was closed, the tabbar would reset back to that save state. I don't know what triggered the save state, but it changed at least once during my debugging. Or maybe it isn't so complex, and I wasn't taking careful enough notes.

:mconley said he suspects the pattern of toolbar manipulation the addon does [1] is the culprit.

[0]: https://addons.mozilla.org/en-US/firefox/addon/rss-icon-in-url-bar/
[1]: https://addons.mozilla.org/ru/firefox/files/browse/257554/file/overlay.js#top

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hm, so I took a closer look at the code in [1], and it looks like what's happening is that on add-on init, the add-on caches the value of currentSet before it injects itself, and then on uninit, sets the toolbar back to the cached currentSet.

So I suspect this was a problem even before CustomizableUI was introduced.

I think this add-on needs to be altered to use CustomizableUI to add itself to the toolbar.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey jorge - can we contact this add-on author to have them update their add-on? Or, alternatively, point to a place where I (or someone else) can submit a patch?

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

I contacted the developer through AMO.

Comment 4

[:Gijs (he/him)]

This was fixed in bug 1341562, but also no more legacy add-ons, so resolving as WFM.