1101793 - delete single quote in first layer of german keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Anton]

Attachment: german-keyboard.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141013195847

Steps to reproduce:

1. open german keyboard


Actual results:

first layer of keyboard appers with letters, single quote and dot.

the single quote makes the second row of the first layer broader and malformed. therefore it's more difficult to type. In addition, there is already a single quote on the second layer.


Expected results:

first layer of keyboard should apper without single quote

Comment 1

[Anton]

in case this is beginner friendly bug a would like to fix it, too

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

According to this comment, it should be ok to remove it from the first (default) page of German layout,
bug 826038 comment 9.

And the code lives in,
https://github.com/mozilla-b2g/gaia/blob/ba0337ffddb62ef3cf388b904e25966d30c89609/apps/keyboard/js/layouts/de.js#L28

Anton, are you interested in fixing this issue?
If you need more information for fixing this, please help set needinfo to me.

If this is the first time for you to work on Gaia issue, you could start from here,
https://github.com/mozilla-b2g/gaia/blob/master/CONTRIBUTING.md

Comment 3

[Anton]

Yes, I am interested. You can assign me

Comment 4

[Mike Hoye [:mhoye]]

Hi, Anton - we can assign this to you as soon as you push up a first try at a patch. Let us know how we can help you do that!

Comment 5

[Giovanny Gongora [:gioyik]]

Attachment: Github PR

Comment 6

[Giovanny Gongora [:gioyik]]

It's ok the PR submitted or more changes are needed?

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8546289 [details] [review]
Github PR

Looks good.
Thanks.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

There are some extra space in the layout definition file, please help fix them in your patch if you could help.

Please just leave them as is if you don't know what to do and set "checkin-needed" in the keyword to ask for checking in your patch.
Thanks.

Comment 9

[Giovanny Gongora [:gioyik]]

Rudy, I deleted the extra space. Could you check it and tell me if is ok?

Thanks

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

There is another extra space at Line 23.
BTW, could you squash the commits?

Thanks.

Comment 11

[Giovanny Gongora [:gioyik]]

Changes on Line 23 are done and the PR has squashed commits. Is everything ok?

Thanks

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, thank you very much for your work!
Now our source tree is closed, so that I cannot merge your patch.

Will set checkin-needed first and keep the ni as is.

Comment 13

[Giovanny Gongora [:gioyik]]

Thank you. Let me know if there's something where I can help.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/6a9e87729aff9534f00afba7367eb4aded4e51e2

Comment 15

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: The single quote does not exist on the first layer of the German keyboard.

Device: Flame Master (319mb, full flash)
Build ID: 20150129010239
Gaia: 9d2378a9ef092ab1fc15c3a9f7fc4171aab59d57
Gecko: 6bfc0e1c4b29
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0