1101897 - "Rows per page" to "Pictures per page"

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2014-11-19 14.39.00.png

On the Picture Gallery view (in management) there's a widget at the bottom that says "Rows per page" but what you're selecting is how many pictures per page.

Comment 1

[Anurag Chaudhury]

Hi Peter,

I made the change and committed the changes. However, I accidentally made the commit into the existing pull request

https://github.com/mozilla/airmozilla/pull/127

Sorry about that. I'll be more careful next time so as to issue a new pull request.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/d7d6c0277658dadcdb94cf744c08d9a483bd7290
Fixes Bug 1101897-"Rows per page" to "Pictures per page"

Comment 3

[Peter Bengtsson [:peterbe]]

We changed it so that it affects all places where that snippet is used. On the Picture Gallery we need it to say "Pictures per page" on the Event Manager it needs to say "Rows per page".

Comment 4

[Anurag Chaudhury]

Hey Peter, but they both use _angular_pagesize, so should we add in a function which depending on the parameter passed produces the label as "Rows per page" or "Pictures per page"?

Comment 5

[Peter Bengtsson [:peterbe]]

(In reply to Anurag Chaudhury from comment #4)
> Hey Peter, but they both use _angular_pagesize, so should we add in a
> function which depending on the parameter passed produces the label as "Rows
> per page" or "Pictures per page"?

Yeah, we'll using a trick to set an exception outside the inclusion of _angular_pagesize. I actually already have a solution in place. Just haven't merged it yet.

Comment 6

[Anurag Chaudhury]

(In reply to Peter Bengtsson [:peterbe] from comment #5)
> (In reply to Anurag Chaudhury from comment #4)
> > Hey Peter, but they both use _angular_pagesize, so should we add in a
> > function which depending on the parameter passed produces the label as "Rows
> > per page" or "Pictures per page"?
> 
> Yeah, we'll using a trick to set an exception outside the inclusion of
> _angular_pagesize. I actually already have a solution in place. Just haven't
> merged it yet.

Oh, I see. In that case, I won't start working on it.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/8f208e9226d39756b2d0751cd50584c1d4e9fee7
fixes bug 1101897 - angular pagesize variable label