1102017 - e10s - fix browser_bug462289.js

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (he/him)]

1064 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js | middle-button mousedown on selected tab2 does not activate tab - Didn't expect [object XULElement], but got it
Stack trace:
chrome://mochikit/content/browser-test.js:test_isnot:838
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step6:72
null:null:0

Not sure what's going on here, but the previous comment indicates this used to crash and time out before... so, progress? The test still needs fixing, however!

Comment 1

[Tracy Walker [:tracy]]

I'm getting the same 3 failures in this test on e10s and non-e10s

Browser Chrome Test Summary
	Passed: 11
	Failed: 3
	Todo: 0
*** End BrowserChrome Test Results ***
The following tests failed:
26 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug462289.js | tab key to selected tab1 activates tab - Got [object HTMLInputElement], expected [object XULElement]
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:940
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step3:41
27 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug462289.js | 3rd click on activated tab1 keeps tab activated - Got [object HTMLInputElement], expected [object XULElement]
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:940
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step4:50
28 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug462289.js | click on tab2 while tab1 is activated activates tab - Got [object XULElement], expected [object XULElement]
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:940
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step5:61

Comment 2

[Dão Gottwald [:dao]]

Pretty sure bug 1009628 broke this by adjusting focus later than we used to.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8726151 [details] [diff] [review]
patch

Review of attachment 8726151 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Dao!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0e4a7aef432e

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40046fe842f0

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e4a7aef432e