1102161 - [Bluetooth] Port Bug 1100883 to bluetooth2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1102161: Move helpers of |BluetoothServiceBluedroid| into its namespace

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1102161: Move |ToggleBtAck| into |BluetoothService|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1102161: Replace most instances of |ToggleBtAck| with calls to |AcknowledgeToggleBt|

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1102161: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification|

Comment 5

[Ben Tian (inactive)]

Comment on attachment 8528366 [details] [diff] [review]
[01] Bug 1102161: Move helpers of |BluetoothServiceBluedroid| into its namespace

Review of attachment 8528366 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +133,1 @@
>  : public BluetoothProfileResultHandler

nit: indent 2 spaces for consistency.

@@ +274,1 @@
>  : public BluetoothProfileResultHandler

nit: indent 2 spaces for consistency.

Comment 6

[Ben Tian (inactive)]

Comment on attachment 8528367 [details] [diff] [review]
[02] Bug 1102161: Move |ToggleBtAck| into |BluetoothService|

Review of attachment 8528367 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8528368 [details] [diff] [review]
[03] Bug 1102161: Replace most instances of |ToggleBtAck| with calls to |AcknowledgeToggleBt|

Review of attachment 8528368 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Ben Tian (inactive)]

Comment on attachment 8528369 [details] [diff] [review]
[04] Bug 1102161: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification|

Review of attachment 8528369 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +1074,5 @@
>  //
>  // Bluetooth notifications
>  //
>  
> +/* |ProfileDeinitResultHandler| collect the results of all profile

collects

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1102161: Move helpers of |BluetoothServiceBluedroid| into its namespace (v2)

Changes since v1:

  - fixed indention

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1102161: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification| (v2)

Changes since v1:

  - rebased on [01]
  - fixed typo in comment

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks, Ben!

https://hg.mozilla.org/integration/b2g-inbound/rev/3d8f1f1dd2ea
https://hg.mozilla.org/integration/b2g-inbound/rev/2c28faa8ab18
https://hg.mozilla.org/integration/b2g-inbound/rev/a9061480fcb1
https://hg.mozilla.org/integration/b2g-inbound/rev/8b87f0548140

https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=8b87f0548140

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3d8f1f1dd2ea
https://hg.mozilla.org/mozilla-central/rev/2c28faa8ab18
https://hg.mozilla.org/mozilla-central/rev/a9061480fcb1
https://hg.mozilla.org/mozilla-central/rev/8b87f0548140