Closed Bug 1102853 Opened 10 years ago Closed 8 years ago

Windows 8 x64 PGO builds fail when trying to update the Chromium sandbox code to commit 9522fad406dd161400daa518075828e47bd47f60

Categories

(Core :: Security: Process Sandboxing, defect)

Product:
Core
Component:
Security: Process Sandboxing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

(Whiteboard: sbwc2)

User Story

This is just to keep track of the fact that we've had to disable PGO in some way for the Chromium sandbox code on Windows x64 builds.

We should see if we can re-enable this when we update to a newer Chromium commit.

Attachments

(1 file)

Remove PGO exception for sharedmem_ipc_client.cc
1.39 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
See user story.
Move process sandboxing bugs to their new, separate component.

(Sorry for the bugspam; filter on 3c21328c-8cfb-4819-9d88-f6e965067350.)
Component: Security → Security: Process Sandboxing
Whiteboard: sbwc2
Depends on: vs2015
Flags: needinfo?(bobowen.code)
This problem with PGO builds appears to have gone now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab49f568aca4f2a6a4b36d9f4558eb7151ad8f0

MozReview-Commit-ID: Qx44MNtns8
Attachment #8797400 - Flags: review?(mh+mozilla)
Assignee: nobody → bobowen.code
Status: NEW → ASSIGNED
Flags: needinfo?(bobowen.code)
Attachment #8797400 - Flags: review?(mh+mozilla) → review+
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cad4dafdc225
Remove PGO exception for sharedmem_ipc_client.cc. r=glandium
https://hg.mozilla.org/mozilla-central/rev/cad4dafdc225
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: