Closed Bug 1103812 Opened 10 years ago Closed 9 years ago

[Settings][Dialog] call_settings/fdn/authorized_numbers/add_contact should be shown as a dialog

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:+)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g +

People

(Reporter: eragonj, Assigned: eragonj)

References

Details

Attachments

(1 file)

patch on master
46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review 
As title, call_settings/fdn/authorized_numbers/add_contact should be shown as a dialog. We should use settings dialog to show it.
blocking-b2g: --- → backlog
tracking-b2g: --- → +
Assignee: nobody → ejchen
Attached file patch on master — 
Arthur, can you help me review this patch ? In this patch, I use dialogService to show the fdnDialog and removed some hacks we made last year. Hope this patch looks nice to you, thanks !
Attachment #8539958 - Flags: review?(arthur.chen)
Comment on attachment 8539958 [details] [review]
patch on master

Good work! r=me with the comment addressed, thanks!
Attachment #8539958 - Flags: review?(arthur.chen) → review+
Thanks all, merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/5f73fb1537fe66352d44b244c89d32013e1f2f71
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: