1103819 - Enable parallel build by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Ricky Chien [:rickychien] (inactive)]

I think parallel build is stable now, it's time to enable it by default.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

try result?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Push to try:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=807dba11c777

waiting for green.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8527439 [details] [review]
Gaia PR

Try result seems good. let's merge it and see if there's anything we haven't considered yet.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/408130c5845ba3c4ec255bb1e29de270a81165d5

Comment 6

[Carsten Book [:Tomcat]]

reverted in case this also causing https://treeherder.mozilla.org/ui/logviewer.html#?job_id=890173&repo=b2g-inbound

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR v2

PR has been updated. Fix windows path issue.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8529556 [details] [review]
Gaia PR v2

r=gduan, I think we can merge it if window/linux/mac can pass.
So, the reason of last backout is due to 2 reasons,
1. We throw error while l10n resource is not found instead of console.warn from a recent commit.
2. Communication and callscreen might have race condition while building in parallel.
That's why we put some workaround in this patch. They should be removed til bug 1093267 is fixed.

I just found out that we cannot execute 'make APP=callscreen' due to reason 1. We should also highlight it.

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Thanks George's help for finding out root cause.

Merged.

https://github.com/mozilla-b2g/gaia/commit/b29f75d68e037fa74620d55fdbd945880065d274

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Added workaround for callscreen will increase some building time. I'm looking forward to waiting bug 1093267 to be fixed.