1104208 - Handler function JSPropertyProvider threw an exception: TypeError: aName is not an identifier

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect)

Description

[Tom Tromey :tromey]

I was using the browser toolbox console.  While stopped at a
breakpoint I typed "markers[0].".  After typing the "." I got
the appended exception.

The root of the problem is calling getVariable with the empty
string.  It seems to me that getVariableInEnvironment should
probably catch exceptions here, because I think it doesn't make
sense to show a stack trace on any user input here, even invalid.


Handler function JSPropertyProvider threw an exception: TypeError: aName is not an identifier
Stack: DebuggerEnvironmentSupport.getProperty@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:1178:18
getExactMatch_impl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:1110:16
getVariableInEnvironment@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:1008:10
JSPropertyProvider@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:900:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
WCA_onAutocomplete@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webconsole.js:826:18
DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1485:15
DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:461:9
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
EventLoop.prototype.enter@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:455:5
ThreadActor.prototype._pushThreadPause@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:650:5
ThreadActor.prototype._pauseAndRespond@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:824:7
ThreadActor.prototype._makeSteppingHooks/steppingHookState.pauseAndRespond@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:956:16
ThreadActor.prototype._makeOnStep/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:937:1
exports.TimelineActor<._pullTimelineData@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/timeline.js:166:1
exports.TimelineActor<._pullTimelineData/this._dataPullTimeout<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/timeline.js:177:7
notify@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/timers.js:40:9
Line: 1178, column: 17 DevToolsUtils.js:59:0

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The big is 4 years old and the code in JsPropertyProvider changed significantly. I've been working on this file for the 2 previous cycle and I didn't saw any exception thrown (even in the browser toolbox console).
I think it's safe to close this bug.