110450 - javascript strict warnings in EditorPublish.js

Status: VERIFIED DUPLICATE of bug 88208

(SeaMonkey :: Composer, defect)

Description

[Henrik Gemal]

Warning: reference to undefined property gDialog.SiteList
Source File: chrome://editor/content/EditorPublish.js
Line: 295

Warning: reference to undefined property gDialog.PageTitleInput
Source File: chrome://editor/content/EditorPublish.js
Line: 289

Warning: reference to undefined property gDialog.TabPanels
Source File: chrome://editor/content/EditorPublish.js
Line: 335

build 20011115

Comment 1

[Syd Logan]

This happens in a debug build by doing what?

Comment 2

[Henrik Gemal]

start Compose
select File -> Publish -> Publish

remember to have js strict warnings set to on via prefs -> debug

Comment 3

[Alex Vincent [:WeirdAl]]

I think the three above strict JS warnings are no longer in effect.  Note in
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EditorPublish.js
lines 50, 55, and 57.

In build Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20020105 I get:

Warning: test for equality (==) mistyped as assignment (=)?
Source File: chrome://editor/content/EditorPublish.js
Line: 160, Column: 26
Source Code:
          if (len = urlLen)

Patch for this strict warning coming up.

Comment 4

[Alex Vincent [:WeirdAl]]

Attachment: patch for comparison instead of assignment strict warning

Comment 5

[Alex Vincent [:WeirdAl]]

Adding patch keyword as I cannot check this in.

Comment 6

[Stephen Walker]

brade: can you take a look at Alex's patch?

Comment 7

[Kathleen :Brade]

Comment on attachment 63704 [details] [diff] [review]
patch for comparison instead of assignment strict warning

r=brade

Comment 8

[Kathleen :Brade]

-->cmanske who has this change in his tree already

Comment 9

[Charles Manske]

Yep, I have this in my latest work for bug 88208

*** This bug has been marked as a duplicate of 88208 ***

Comment 10

[sujay]

v

Comment 11

[sujay]

Henrik, can you test this out using 3/8 build...fix for 88208 went
into this build, so you should not see this problem anymore..

Please verify...and REOPEN this bug if you still see the problem..thanks!

Comment 12

[Henrik Gemal]

v dupe. I cant get any strict warn anymore...