1104619 - (sb-audio) [meta] Sandboxing improvements when audio playback & recording are remoted

Status: NEW

(Core :: Security: Process Sandboxing, defect, P3)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

WIP is being done on this branch: 
https://github.com/gcp/gecko-dev/tree/sandbox-av
https://github.com/gcp/gecko-dev/compare/sandbox-av

Comment 2

[Julian Hector [:tedd] [:jhector]]

Should this be tracked by sandboxing? It looks like this could fix Bug 1259283.

Comment 3

[Julian Hector [:tedd] [:jhector]]

Moving to sblc2 because this is currently not blocking enabling seccomp on nightly. However, it will allow us to revert the patch landed as part of Bug 1259508, once audio is remoted.

Comment 4

[Julian Hector [:tedd] [:jhector]]

Discussed this with :gcp over irc, he is not currently working on it.

Comment 5

[Paul Adenot (:padenot)]

We should have a look at how chromium does this before proceeding. Also don't hesitate to ask any question, this is full of gotchas.

This is the code on the host side (= Chrome process for us): https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/audio_input_renderer_host.cc?sq=package:chromium&rcl=1474529952&l=349

Comment 6

[Julian Hector [:tedd] [:jhector]]

Thank you very much.

So far my approach is to remote the cubeb API found in cubeb.h. But I am currently dealing with a threading issue since I created a sync protocol. It seems that the Send method is called from a thread it can't block on.

I probably have to do something similar to the LockAndDispatch [1] that :gcp did on PCameras, which makes this slightly more complicated.

[1] http://searchfox.org/mozilla-central/rev/8910ca900f826a9b714607fd23bfa1b37a191eca/dom/media/systemservices/CamerasChild.cpp#188

Comment 7

[Julian Hector [:tedd] [:jhector]]

Oh and this is my working branch:

https://github.com/jhector/gecko-dev/tree/bug-1104619-remote-audio

Comment 8

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Retitling this bug to match what its new purpose seems to be.  The audio remoting discussed in previous comments seems to now be covered in bug 1362220.