1104822 - Clean up strategy on signing servers is based on age of artefacts, but should be based on available disk space

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

See:
https://github.com/mozilla/build-tools/blob/master/lib/python/signing/server.py#L408 -> https://github.com/mozilla/build-tools/blob/master/lib/python/signing/server.py#L331

The reason this is bad, is that when we have a lot of releases all at once, we can quickly use up available disk space.

Ideally the algorithm should keep a certain amount of disk space free, regardless of how old the artefacts are.

Comment 1

[[e-mail] (:bhearsum)]

We should probably factor in age to a degree, at least to the point of "don't delete things that are less than X min old", where X is higher than the amount of time it takes to sign something and the slave to get it. Otherwise we risk deleting artifacts that are still needed.

Comment 2

[Chris Cooper [:coop] (he/him)]

Attachment: [puppet] Keep signed files for 4 hours instead of 8

Comment 3

[Pete Moore [:pmoore][:pete]]

Let's keep this bug open for the general problem, since in bug 1072274 we went from 12 hours to 8 hours, in this bug we are now going from 8 hours to 4 hours, and at some point we may need to go from 4 hours to 2 hours unless we switch the underlying algorithm.

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8546685 [details] [diff] [review]
[puppet] Keep signed files for 4 hours instead of 8

Review of attachment 8546685 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/puppet/rev/bda33a2528bf