Closed Bug 1105349 Opened 10 years ago Closed 7 years ago

Remove app_api_all waffle flag

Categories

(Socorro :: Webapp, task)

x86
macOS
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: peterbe, Assigned: peterbe)

Details

Attachments

(1 file)

We're currently protecting all of the public web api with the app_api_all waffle flag. 

That means we have to rely on a DB call before it can do anything. And this can error out like it has done 3,300 times on stage https://errormill.mozilla.org/webtools/socorro-stage/group/169483/

Removing it, we can potentially speed up the public API a lot.
Do you know any good reason to keep it? 

The way I see it, waffle flags are meant for "soft roll-out" of new features. They are cumbersome for developers who don't know the management commands by heart and the waffle machine doesn't use the caching framework.
Flags: needinfo?(chris.lonnen)
Flags: needinfo?(adrian)
I don't know of a good reason to keep it.

We may want to look into a waffle replacement in the future that's a little easier to work with.
Flags: needinfo?(chris.lonnen)
waffle switches are here to make sure we have an easy way to switch off a risky feature. Once we know that feature is safe, there is no point on keeping the switch around. So yes, let's remove the API waffle switch! :)

As a side-note, maybe we should file an end-of-life bug for each waffle switch that we introduce in the code? With some kind of reminder that we need to do it after ~2/3 months?
Flags: needinfo?(adrian)
Assignee: nobody → peterbe
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9120598a186af10076a0607c573d4f0ba65242b0
fixes bug 1105349 - Remove app_api_all waffle flag (#3589)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: