Open
Bug 1105465
Opened 10 years ago
Updated 2 years ago
Separate git source info from MOZILLA_OFFICIAL
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
NEW
People
(Reporter: jryans, Unassigned)
References
Details
In bug 1043390, the Git info from about:buildconfig was hidden behind MOZILLA_OFFICIAL to help Windows build environments without Git available. Ideally, I'd like to keep this Git info, but without changing MOZILLA_OFFICIAL, as there are various other places where MOZILLA_OFFICIAL == false is used to mean "local developer", such as for Fennec debugging[1]. What's the best path to keep Git source info when Git is available, but also leaving MOZILLA_OFFICIAL alone? [1]: http://hg.mozilla.org/mozilla-central/annotate/7bcc6573d204/mobile/android/base/AndroidManifest.xml.in#l89
Reporter | ||
Comment 1•10 years ago
|
||
Mike, maybe you have an idea based on bug 1043390 comment 25? Should there be a new flag for Git info that is not set on Windows or something?
Flags: needinfo?(mh+mozilla)
Comment 2•10 years ago
|
||
We could presumably just check for git in configure, and define something based on that.
Comment 3•10 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] from comment #0) > http://hg.mozilla.org/mozilla-central/annotate/7bcc6573d204/mobile/android/ > base/AndroidManifest.xml.in#l89 FWIW, if the intent is for developer builds to be debuggable, it should be based on DEVELOPER_OPTIONS, not !MOZILLA_OFFICIAL. > Ideally, I'd like to keep this Git info I'm not sure it's valuable, but if you _really_ want that info, then comment 2 is probably the best option.
Flags: needinfo?(mh+mozilla)
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•