1105615 - Make IDBObjectStoreParameters.keyPath a union

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Boris Zbarsky [:bzbarsky]]

There's a TODO in the IDL there, and I see no reason not to fix it...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make IDBObjectStoreParameters.keyPath a union instead of using "any" for it

The one thing to watch out for is zero-length arrays.  As far as I can tell those used to throw from Parse() but now won't.  IS that a problem?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Make IDBObjectStoreParameters.keyPath a union instead of using "any" for it

Comment 3

[Boris Zbarsky [:bzbarsky]]

> IS that a problem?

Looks like yes.  We have tests for it, and the spec says empty array is not a valid keypath.  I wonder why the Parse() overload that takes an array doesn't enforce that...  So fixed in that updated patch.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Make IDBObjectStoreParameters.keyPath a union instead of using "any" for it

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8529574 [details] [diff] [review]
Make IDBObjectStoreParameters.keyPath a union instead of using "any" for it

Review of attachment 8529574 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/KeyPath.cpp
@@ +266,5 @@
>  
> +  if (aValue.Value().IsString()) {
> +    return Parse(aValue.Value().GetAsString(), aKeyPath);
> +  }
> +

MOZ_ASSERT(aValue.Value().IsStringSequence()) ?

@@ +269,5 @@
> +  }
> +
> +  const Sequence<nsString>& seq = aValue.Value().GetAsStringSequence();
> +  if (seq.Length() == 0) {
> +    return NS_ERROR_DOM_SYNTAX_ERR;

Previously we returned NS_ERROR_FAILURE.
We return DOM_SYNTAX_ERR in CreateObject.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> MOZ_ASSERT(aValue.Value().IsStringSequence()) ?

Done.

> Previously we returned NS_ERROR_FAILURE.
> We return DOM_SYNTAX_ERR in CreateObject.

Ah, I see.  Ok, switched back to NS_ERROR_FAILURE, since upstream fixes it up.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a84e8a699159

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a84e8a699159