Closed
Bug 1105870
Opened 10 years ago
Closed 10 years ago
Fix -Wunused-function warnings-as-errors in nonunified build of dom/canvas
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
| Tracking | Status | |
|---|---|---|
| firefox35 | --- | unaffected |
| firefox36 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.47 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
These `IsValidFBO*ColorFormat` functions in dom/canvas/WebGLFramebuffer.cpp are unused, though clang only warns about them in nonunified builds (perhaps clang does less introspection on the huge unified .cpp files). These functions' call points were removed by bug 1102667. > dom/canvas/WebGLFramebuffer.cpp:224:1: error: unused function 'IsValidFBOTextureColorFormat' [-Werror,-Wunused-function] > dom/canvas/WebGLFramebuffer.cpp:259:1: error: unused function 'IsValidFBORenderbufferColorFormat' [-Werror,-Wunused-function]
Attachment #8529949 -
Flags: review?(jgilbert)
|
||
Updated•10 years ago
|
Attachment #8529949 -
Flags: review?(jgilbert) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9807bca1e63
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d9807bca1e63
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•