1106428 - SIMD test cases: implement int32x4.bool test case

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:ProgramFOX]

There is no SIMD test case for the int32x4.bool method.

Comment 1

[:ProgramFOX]

Attachment: Added int32x4.bool test case

Proposed patch that adds a test case for int32x4.bool.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8530656 [details] [diff] [review]
Added int32x4.bool test case

Review of attachment 8530656 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, could you try-server it please, update the commit message and add the checkin-needed keyword when it's ready?

Comment 3

[:ProgramFOX]

Try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ec6743debc57

Comment 4

[:ProgramFOX]

I forgot to run jsreftests on that try push, cancelled it and pushed a new one:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=7a3afa037fc4

Comment 5

[:ProgramFOX]

The try push succeeded, adding checkin-needed.

Note that you'll only see the empty patch with the try syntax, but I asked about this on #developers, and birtles said that the try server already had the changes because I pushed the second push quickly after the first one:
http://logs.glob.uno/?c=mozilla%23developers&s=4+Dec+2014&e=4+Dec+2014#c1113113

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8ec192cf912

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8ec192cf912