110666 - MimeInlineText leaks encoder and decoder

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[David :Bienvenu]

MimeInlineText has a couple com ptrs as member variables. These don't get
released, because MimeInlineText is a struct, not a class, and thus doesn't have
a destructor. The simple fix is to make it a class, which I'll try.

Comment 1

[David :Bienvenu]

I also looked through the rest of libmime for similar mistakes and found one in
mime_draft_data which has an nsCOMPtr <nsIMsgIdentity> which is never freed.

Comment 2

[David :Bienvenu]

Attachment: proposed fix

fix is to free up comptrs in the finalize method. Please review.

Comment 3

[David :Bienvenu]

this leaks on every message we read.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 58288 [details] [diff] [review]
proposed fix

sr=sspitzer

you leak finding (and killing) monster!

Comment 5

[Jean-Francois Ducarroz]

Comment on attachment 58288 [details] [diff] [review]
proposed fix

R=ducarroz

Comment 6

[David :Bienvenu]

fix checked in.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Interesting, is there a more complete fix in
http://bugzilla.mozilla.org/show_bug.cgi?id=110701?

Comment 8

[David :Bienvenu]

*** Bug 110701 has been marked as a duplicate of this bug. ***

Comment 9

[David :Bienvenu]

no, my fix is simpler.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Different bug?

[W] MLK: Memory leak of 1 byte from 1 block allocated in PL_strdup
        Distribution of leaked blocks
        Allocation location
            malloc         [msvcrt.DLL]
            PL_strdup      [strdup.c:46]
            nsPrefService::GetCharPref(char const*,char * *) 
[nsPrefService.h:57]
            MimeInlineTextPlain_parse_begin [mimetpla.cpp:165]
            MimeUntypedText_open_subpart [mimeunty.cpp:369]
            MimeUntypedText_parse_line [mimeunty.cpp:183]
            convert_and_send_buffer [mimebuf.cpp:168]
            mime_LineBuffer [mimebuf.cpp:255]
            MimeObject_parse_buffer [mimeobj.cpp:255]
            convert_and_send_buffer [mimebuf.cpp:168]
            mime_LineBuffer [mimebuf.cpp:255]
            MimeObject_parse_buffer [mimeobj.cpp:255]
            nsStreamConverter::OnDataAvailable(nsIRequest *,nsISupports 
*,nsIInputStream *,UINT,UINT) [nsStreamConverter.cpp:919]
            nsDocumentOpenInfo::OnDataAvailable(nsIRequest *,nsISupports 
*,nsIInputStream *,UINT,UINT) [nsURILoader.cpp:240]
            nsStreamListenerTee::OnDataAvailable(nsIRequest *,nsISupports 
*,nsIInputStream *,UINT,UINT) [nsStreamListenerTee.cpp:56]
            nsOnDataAvailableEvent0::HandleEvent(void) 
[nsAsyncStreamListener.cpp:426]
            nsStreamListenerEvent0::HandlePLEvent(PLEvent *) 
[nsAsyncStreamListener.cpp:113]
            md_EventReceiverProc [plevent.c:1071]
            ScrollDC       [user32.dll]
            ScrollDC       [user32.dll]

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Well, the other 2 mime leaks are fixed, so I'll let this bug stay in scope by
verifying it, and I'll file the new bug (along with steps to reproduce).

Win2k, current trunk CVS pull with Purify.

Comment 12

[David :Bienvenu]

yeah, Stephen, that's a different leak. You can assign the new one to me and cc JF.