1106732 - Test failure 'The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed'' in testSecurity/testSSLDisabledErrorPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Teodor Druta]

Module:    testSSLDisabledErrorPage
Test:      testSecurity/testSSLDisabledErrorPage.js 
Failure:   'The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed'
Branches:  mozilla-aurora, mozilla-beta
Platforms: All
Locale:    All
Report:    http://mozmill-daily.blargon7.com/#/remote/report/bdaefa581a1cff14362f7944d610df05

Reproducible on all platforms.

Comment 1

[Teodor Druta]

Attachment: skipssldisablederrorpage.patch

We have multiple failures in this test we should skip this test on beta and aurora.

Added skip patch.

Comment 2

[Teodor Druta]

Attachment: skipssldisablederrorpage.patch

Sorry, wrong file.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8531170 [details] [diff] [review]
skipssldisablederrorpage.patch

Review of attachment 8531170 [details] [diff] [review]:
-----------------------------------------------------------------

Patch doesn't apply anymore with the other skip, please update. Also the commit message.

Comment 4

[Teodor Druta]

Attachment: skipssldisablederrorpage.patch

Fixed rejections.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8531191 [details] [diff] [review]
skipssldisablederrorpage.patch

Review of attachment 8531191 [details] [diff] [review]:
-----------------------------------------------------------------

This has 4 failures, all on OSX. Please see how often it fails, if you can reproduce. We shouldn't skip otherwise or not on all platforms. Just saw the reports now, sorry.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Teodor Druta from comment #0)
> Branches:  mozilla-aurora, mozilla-beta

The status flags do not match those branches. Can you please fix that? 

Also please see the other correlated failure here which is:

The SSL error message contains disabled information - 'Firefox cannot guarantee the safety of your data on tlsv1-0.mozqa.com because it uses SSLv3, a broken security protocol.' should contain 'ssl_error_no_cypher_overlap'

Seeing this I do not think it is a bug in our test but somehow the certificate still has SSLv3 enabled? This needs more investigation and totally not a skip patch. We only do that for P1 and partly P2.

Comment 7

[Masatoshi Kimura [:emk]]

(In reply to Henrik Skupin (:whimboo) from comment #6)
> The SSL error message contains disabled information - 'Firefox cannot
> guarantee the safety of your data on tlsv1-0.mozqa.com because it uses
> SSLv3, a broken security protocol.' should contain
> 'ssl_error_no_cypher_overlap'
> 
> Seeing this I do not think it is a bug in our test but somehow the
> certificate still has SSLv3 enabled? This needs more investigation and
> totally not a skip patch. We only do that for P1 and partly P2.

Bug 1096695 changed the message from "An error occurred during a connection to write.skyword.com. Cannot communicate securely with peer: no common encryption algorithm(s). (Error code: ssl_error_no_cypher_overlap)" to "Firefox cannot
> guarantee the safety of your data on tlsv1-0.mozqa.com because it uses
> SSLv3, a broken security protocol.".
We should update the test rather than disabling it.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thank you Masatoshi. Given that the mentioned patch landed for 34 and 35, I do not see why the flags have been set wrongly. So I can also only repeat, lets get this fixed. Thanks.

Oh, and given that it is affecting beta and release builds we want to get this fixed sooner than later.

Comment 9

[Cosmin Malutan, [:cosmin-malutan]]

I just checked latest Aurora, Beta and Release
http://mozmill-crowd.blargon7.com/#/remote/report/946d3cd70aaf19c33a8878f8c4b13ea3
http://mozmill-crowd.blargon7.com/#/remote/report/946d3cd70aaf19c33a8878f8c4aee643
http://mozmill-crowd.blargon7.com/#/remote/report/946d3cd70aaf19c33a8878f8c4ade2b9

This bug has been fixed somewhere down the road.
Also this failed only on OSX before and only on en-US. This would come handy, as I checked first on linux until I noticed that and also other locales.

Andreea could you backout the skip?

Comment 10

[Andreea Matei [:AndreeaMatei]]

This is not skipped, it failed only a few times on OSX. We can close it then, I think the SSL error message went back.