Closed
Bug 1106796
Opened 10 years ago
Closed 10 years ago
reference to undefined property this.lastMessage.sourceFolder in resource:///modules/activity/moveCopy.js
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 37.0
People
(Reporter: aceman, Assigned: aceman)
Details
Attachments
(1 file)
|
3.73 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
After moving a message in a POP3 folder I consistently get this warning: Warning: ReferenceError: reference to undefined property this.lastMessage.sourceFolder Source File: resource:///modules/activity/moveCopy.js Line: 129
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
It seems the bug was that the == operator takes precedence before ?: . I also fix some 'let blocks are deprecated' warnings that are issued from the activity manager at the same action (copying/moving a message). Hopefully the blocks didn't do some special hack that will now be broken by unwrapping the block.
Attachment #8536124 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8536124 [details] [diff] [review] patch Review of attachment 8536124 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thx! r=mkmelin
Attachment #8536124 -
Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
|
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/5f3b32931eda -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
You need to log in
before you can comment on or make changes to this bug.
Description
•