1106970 - [Midori 2.0][Music player]The search result cannot match after tapping enter key again.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[sync-1]

FireFox OS V2.0
 
 mozilla build id:20141019000201
 
 DEFECT DESCRIPTION:
 The search result cannot match after tapping enter key again.
 
  REPRODUCING PROCEDURES:
 Pre-condition:MS has some songs;
 
 1.Launch music player;
 2.Slide down screen to search songs;
 3.Input some characters and then can see search results;
 4.Press Enter icon at the lower right corner of the keyboard,the keyboard is hidden and the search results can display;
 5.Again press Enter icon at the lower right corner of the keyboard,the word disappear in search box-->KO1;
 6.Again input some characters and tap enter key,the keyboard is hidden and the search results do not display-->KO2;

Comment 1

[sync-1]

Attachment: PR824965_jrdlog

Comment 2

[sync-1]

Attachment: issue_pic

Comment 3

[sync-1]

Mozilla ID : 1106970

Comment 4

[dingp]

[Blocking Requested - why for this release]:This pr blocked us, please help to fix it.
We hava a elastoplast solution but it will cause another pr.

Comment 5

[Shine(Leave from Mozilla)]

Hi, 
Is this bug reproducible in 1.3 SW?

Comment 6

[dingp]

It can reproduce on 1.3.
Our elastoplast solution is ignore enter key in search, but i don't think this a perfect solution.

Comment 7

[Shine(Leave from Mozilla)]

Attachment: video

we can reproduce on Flame v2.1 and v2.2, but the actual behavior in step 4 and 5 are different from reporter’s.
See attachment: video.MP4 & Flame2.1_logcat_1402.txt & Flame2.2_logcat_1414.txt
Reproducing rate: 0/5
Reproducing steps:
Pre-condition: MS has some songs;
1. Launch music player;
2. Slide down screen to search songs;
3. Input some characters and then can see search results;
4. Press Enter icon at the lower right corner of the keyboard.
** The keyboard is NOT hidden; the search results disappear and the word in search box disappear;
5. Again input some characters and tap enter key.
** The keyboard is NOT hidden and the search results do not display, after tap enter key, the word in search box disappear.

Flame2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0

Flame2.2 build:
Gaia-Rev        984e6d79aa799d2695f9ca132dfdc1665a56c019
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a9fc46355661
Build-ID        20141204040202
Version         37.0a1

Comment 8

[Shine(Leave from Mozilla)]

Attachment: Flame2.1 logcat

Comment 9

[Shine(Leave from Mozilla)]

Attachment: Flame2.2 logcat

Comment 10

[Wesly Huang (EPM)]

[Blocking Requested - why for this release]:

[Triage] Indeed inconvenient to user but not a critical impact considering 2.0 timing, also not a regression. Nom. to 2.1 instead.

Comment 11

[Hema Koka [:hema]]

Dominic or Hub,

Can one of please take a look at this and see if we can fix in master (2.2)

Thanks
Hema

Comment 12

[Hubert Figuiere [:hub]]

Dominic, if you are not actively working on this, I can take it.

Thanks

Comment 13

[Hubert Figuiere [:hub]]

I'll take it. This is just wrong.

Comment 14

[Dominic Kuo [:dkuo]]

(In reply to Hubert Figuiere [:hub] - on PTO 'til 2015 from comment #13)
> I'll take it. This is just wrong.

Thanks Hub, let me know if you have any question!

Comment 15

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636

This should fix the problem. Also in tile mode the keyboard was not the search one.

Comment 16

[Hubert Figuiere [:hub]]

NOTE: I should write an integration test as well.

Comment 17

[Hubert Figuiere [:hub]]

Also one problem that remain is that we should have that bottom right key be neither "search" nor "return" but instead be "hide". At least with this patch it is search.

Comment 18

[Hubert Figuiere [:hub]]

(In reply to Hubert Figuiere [:hub] from comment #17)
> Also one problem that remain is that we should have that bottom right key be
> neither "search" nor "return" but instead be "hide". At least with this
> patch it is search.

Bug 1102481 will somewhat work around this.

Comment 19

[Dominic Kuo [:dkuo]]

Comment on attachment 8553798 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636

Hub, after I tested this patch, I found after we entered some text then tap the enter/search key in the keyboard, though the keyboard will disappear but so does the search results, I think people should expect only dismiss the keyboard and keep the results, right? if so, then we might have to adjust this patch.

Comment 20

[Hubert Figuiere [:hub]]

It has always been like that - just that before it made the search unusable again.

See also bug 1102481 comment 7 which should address your concern.

Comment 21

[Hubert Figuiere [:hub]]

Comment on attachment 8553798 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636

Reworked the patch to actually disable the "enter" button. This make the behaviour consistent with search in Contacts, and this fixes the problem here too.

Comment 22

[Dominic Kuo [:dkuo]]

Comment on attachment 8553798 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636

Looks good to me now, thanks Hub!(A suggestion in the github comments)

Comment 23

[Hubert Figuiere [:hub]]

Taken suggestion into account.

Merged
https://github.com/mozilla-b2g/gaia/commit/adb80fe7bc06abf7c79fb79e7c1a8f6ba79293ae

Comment 24

[Hubert Figuiere [:hub]]

Comment on attachment 8553798 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no regression. This is 2.2+
[User impact] if declined: feature don't work properly. Didn't before anyway.
[Testing completed]: manual testing.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none.

Comment 25

[bhavana bajaj [:bajaj]]

(In reply to Hubert Figuiere [:hub] from comment #24)
> Comment on attachment 8553798 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): no regression. This is 2.2+
> [User impact] if declined: feature don't work properly. Didn't before anyway.
> [Testing completed]: manual testing.
> [Risk to taking this patch] (and alternatives if risky): low
> [String changes made]: none.

Can we add unit/integration tests for this?

Comment 26

[Hubert Figuiere [:hub]]

Right now there is no integration test for this. And I don't think it is trivial, but I do have a Q1 goal to broaden the integration testing for the music app for 3.0. I can make sure this case is handled.

Comment 27

[bhavana bajaj [:bajaj]]

Comment on attachment 8553798 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27636

Requesting QA verification once this lands.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/262cd4df80bd0f4725e81c8a3a90758c07b47f29

Comment 29

[Sue]

Attachment: video.MP4

Hi Hubert,
I have verified this issue on Flame v2.2, and I found the keyboard doesnt's disappear after tapping "search" button at bottom right, and so does the search results. According your comment 17 and comment 21, I have a question, whether the current result is correct or not? I have uploaded the video, could you help to check it? Thanks!
See attachment:video.MP4

Flame 2.2 build:
Build ID               20150203002504
Gaia Revision          cd62ff9fe199fb43920ba27bd5fdbc5c311016fc
Gaia Date              2015-02-03 00:56:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/11d93135c678
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150203.041704
Firmware Date          Tue Feb  3 04:17:15 EST 2015
Bootloader             L1TC000118D0

Comment 30

[Hubert Figuiere [:hub]]

see comment 19, comment 20 and comment 21.

There is an upcoming fix with bug 1102481 to be close to the UX pattern used in contacts.

Comment 31

[Sue]

Attachment: video.MP4

This issue has been verified successfully on Flame 2.2/3.0
When user types in a query that has no results, a message appeared in the space that shows results that says "No music found". When user taps the enter button, no action take place and the user is not taken out of the search flow.
See attachment:video.MP4
Rate:0/5

Flame 2.2 build:
Build ID               20150225002505
Gaia Revision          ca64f2fe145909f31af266b1730874051ba76c78
Gaia Date              2015-02-24 22:06:53
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.041814
Firmware Date          Wed Feb 25 04:18:25 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 build:
Build ID               20150225010244
Gaia Revision          f6bfd854fe4746f21bc006eac145365e85f98808
Gaia Date              2015-02-24 21:10:44
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0a8b3b67715a
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.043702
Firmware Date          Wed Feb 25 04:37:14 EST 2015
Bootloader             L1TC00011880