1107013 - Local Browser Toolbox builds don't clear startup cache

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

If you do an incremental build of the browser to work on changes to the Browser Toolbox itself, the changes may not appear.  Only a full rebuild makes them apply.

This occurs because the child profile's startup cache is outdated, so we need to explicitly clear it in this case.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6667be683040

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1107013/jryans

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

/r/1135 - Bug 1107013 - Clear Browser Toolbox cache for local builds. r=bgrins

Pull down this commit:

hg pull review -r b4983f053cee1a3b284603e8853cf02a0dc29942

Comment 4

[Brian Grinstead [:bgrins]]

https://reviewboard.mozilla.org/r/1133/#review685

::: browser/devtools/framework/ToolboxProcess.jsm
(Diff revision 1)
> +        Services.appinfo.defaultUpdateChannel == "default") {

As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition

Sounds great since it seems it will fix the mysterious problems I've been seeing with the BT not reflecting built changes

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://reviewboard.mozilla.org/r/1133/#review697

> As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition

Okay, I've made this change.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/integration/fx-team/rev/9832a29c55e9

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9832a29c55e9

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1107013 - Clear Browser Toolbox cache for local builds. r=bgrins