1107683 - [Camera][Gecko] (Finally) get rid of CameraControl callbacks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Remove method callbacks from CameraControl, v1

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8533972 [details] [diff] [review]
Remove method callbacks from CameraControl, v1

Removing r? -- this patch doesn't include the unsolicited event callback removal.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Remove method and attribute callbacks from CameraControl, v2

try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b6f016170c93

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8534184 [details] [diff] [review]
Remove method and attribute callbacks from CameraControl, v2

bz: this patch removes all of the method and attribute callbacks, in favour of promises and events.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8534184 [details] [diff] [review]
Remove method and attribute callbacks from CameraControl, v2

Review of attachment 8534184 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/camera/DOMCameraControl.cpp
@@ -1701,5 @@
>        aError, aContext);
>      return;
>    }
>  
> -  DOM_CAMERA_LOGI("DOM OnUserError aContext=%u, aError=0x%x\n", aContext, aError);

We stil need this print.

::: dom/webidl/CameraControl.webidl
@@ -351,5 @@
> -     stop moving the focus position; it can be used to update a UI element to
> -     indicate that the camera is still trying to focus, or has finished. Some
> -     platforms do not support this event, in which case the callback is never
> -     invoked. */
> -  [Pref="camera.control.autofocus_moving_callback.enabled"]

Remove this pref from modules/libpref/init/all.js since we no longer use it?

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8534184 [details] [diff] [review]
Remove method and attribute callbacks from CameraControl, v2

Review of attachment 8534184 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/camera/DOMCameraControl.cpp
@@ -1701,5 @@
>        aError, aContext);
>      return;
>    }
>  
> -  DOM_CAMERA_LOGI("DOM OnUserError aContext=%u, aError=0x%x\n", aContext, aError);

Missed the addition at the top sorry.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8534184 [details] [diff] [review]
Remove method and attribute callbacks from CameraControl, v2

r=me for the webidl changes.  I sorta-skimmed part of the rest, but if you want me to actually look at it at all carefully, please let me know.

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Boris Zbarsky [:bz] from comment #7)

> r=me for the webidl changes.  I sorta-skimmed part of the rest, but if you
> want me to actually look at it at all carefully, please let me know.

Nope -- as long as you're fine with the WebIDL, the rest is just deleting the backing code. Thanks!

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Remove method and attribute callbacks from CameraControl, v2.1 r=aosmond,bz

Fix a couple of broken tests; carrying r+ forward.

try-push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=084cb33dddec

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Remove method and attribute callbacks from CameraControl, v2.2 r=aosmond,bz

Fix the (last?) broken test. Carrying r+ forward.

try-push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c6ba18aec720

Comment 11

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/b2g-inbound/rev/12c5cc6e88b3

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/12c5cc6e88b3