1107814 - Mark more source directories as FAIL_ON_WARNINGS, some conditionally for just clang or MSVC

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: part-1-unconditional-FAIL_ON_WARNINGS.patch

Part 1: Mark more directories as FAIL_ON_WARNINGS (unconditionally for all compilers)

Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=08ac647efbcd

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-2-conditional-FAIL_ON_WARNINGS.patch

Daniel: do you mind testing these FAIL_ON_WARNINGS patches with your Ubuntu clang build environment? Your clang always seems to find problems that our OS X clang does not. :)

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8532428 [details] [diff] [review]
part-2-conditional-FAIL_ON_WARNINGS.patch

These don't break anything for me, in my --enable-debug --disable-optimize --enable-warnings-as-errors build. (with clang 3.5 on Ubuntu 14.10)

(I dropped all my other --enable/disable flags to be sure I wasn't turning off any code that's being declared to be warning-free here.)

Thanks!

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8532427 [details] [diff] [review]
part-1-unconditional-FAIL_ON_WARNINGS.patch

Part 1: Mark more directories as FAIL_ON_WARNINGS (unconditionally for all compilers)

Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=08ac647efbcd

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8532428 [details] [diff] [review]
part-2-conditional-FAIL_ON_WARNINGS.patch

Part 2: Mark some directories as FAIL_ON_WARNINGS conditionally for some compilers.

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b14b9b335d4e
https://hg.mozilla.org/integration/mozilla-inbound/rev/2147895c5dc4

Comment 6

[Chris Peterson [:cpeterson]]

Back out part of changeset 2147895c5dc4 (bug 1107814) because of non-unified OS X build breakage on a CLOSED TREE. a=philor

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8da0f3cee92

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b14b9b335d4e