1108685 - describecomponents.cgi?product=X shouldn't list default assignee if it's "nobody"

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[:Gijs (he/him)]

https://bugzilla.mozilla.org/describecomponents.cgi?product=Core

Find bar says 100+ matches for " Nobody; OK to take it and work on it ".

Let's not do that.

(not sure if that's a bmo or Bugzilla thing to fix, might be harder to do in the general case?)

Comment 1

[David Lawrence [:dkl]]

An assignee for a component in Bugzilla is mandatory so BMO uses a dummy account called [e-mail] to fill that requirement. The describe components page is just displaying whatever is stored in the database. So we will need to make a customization to the BMO code itself to hide the assignee value if equal to [e-mail].

dkl

Comment 2

[Andre Klapper]

What's the actual problem with the curent behavior?
The only problem 'description' I see is "Let's not do that." without any arguments.

Comment 3

[:Gijs (he/him)]

(In reply to Andre Klapper from comment #2)
> What's the actual problem with the curent behavior?

It's repetitive, uninformative, and needlessly takes up space. Knowing that bugs there are by default not assigned to anybody doesn't help, err, anybody. We should just not display it at all unless the assignee is non-empty, so to speak, as 'empty' is what [e-mail] stands for (see comment #1).

In essence, my argument is that it's about as useful as padding out the descriptions with an extra line saying "mozilla is awesome" for every description. Correct information, but doesn't add anything to the page, and wastes space - so we should get rid of it.

Comment 4

[David Lawrence [:dkl]]

Attachment: 1108685_1.patch

I agree that this is possibly low priority, but being that it was a small change to implement, I am putting it up for review/feedback anyway.

Comment 5

[:glob ✱]

Comment on attachment 8533906 [details] [diff] [review]
1108685_1.patch

Review of attachment 8533906 [details] [diff] [review]:
-----------------------------------------------------------------

if we're to do this correctly, we should also be skipping *.bugs default owners (mostly for the bugzilla and infra products).

however i don't think showing the default assignee and qa-contact on this page provides any value.
instead of selectively removing values, let's remove both those fields completely.

Comment 6

[David Lawrence [:dkl]]

Attachment: 1108685_2.patch

Ok. So I took a different approach.

Comment 7

[:glob ✱]

Comment on attachment 8545410 [details] [diff] [review]
1108685_2.patch

Review of attachment 8545410 [details] [diff] [review]:
-----------------------------------------------------------------

this looks awesome, r=glob

::: extensions/BMO/template/en/default/reports/components.html.tmpl
@@ +16,5 @@
> +  # Rights Reserved.
> +  #
> +  # Contributor(s): Bradley Baetz <[e-mail]>
> +  #                 Max Kanat-Alexander <[e-mail]>
> +  #%]

change this license please

@@ +39,5 @@
> +  font-weight: normal;
> +}
> +.product_desc, .component_desc {
> +  padding-left: 1em;
> +  font-size: 1em;

i suggest setting max-height:none here.

Comment 8

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   0ed20de..570476d  master -> master

Comment 9

[David Lawrence [:dkl]]

This is live now