1108759 - libmozsandbox breaks no-opt B2G build

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

libmozsandbox needs to USE_LIBS mfbt (or maybe mozglue?) because of the symbol dependency on mozilla::unused present on no-optimization builds.

This breaks the B2G no-optimization build, which appears to be very uncommon — this has probably been broken for months (since bug 1059038 landed), and so far only one person has run into it — but it should be fixed.

(Note: the ICS B2G no-opt build is broken both by this and by ICEs in Neon-specific code in libvpx and skia, but bug 1056337 could fix that.)

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1108759-noopt-mfbt-hg0.diff

Seems to not break any of the existing builds: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=42599d6539fc

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

…or maybe this is fallout from bug 1077148, and the correct fix is to change SharedLibrary to GeckoSharedLibrary?

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8533441 [details] [diff] [review]
bug1108759-noopt-mfbt-hg0.diff

Review of attachment 8533441 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/sandbox/linux/moz.build
@@ +45,5 @@
>          'rt',
>      ]
>  
> +USE_LIBS += [
> +    'mfbt',

make that mozglue, and only in the case you define a SharedLibrary.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Patch [v2]

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5059c952f4f1

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd8ab8e5292d

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd8ab8e5292d