Closed Bug 1108981 Opened 10 years ago Closed 10 years ago

[Loop] Sometimes, Rooms list appears empty on app. start

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: frsela, Assigned: frsela)

References

Details

Attachments

(3 files, 1 obsolete file)

Proposed patch
61 bytes, text/x-github-pull-request
crdlc
: review+
crdlc
: feedback+
Details | Review
Race condition fix
61 bytes, text/x-github-pull-request
crdlc
: review+
Details | Review
Github pull request
61 bytes, text/x-github-pull-request
frsela
: review+
Details | Review 
After some Loop runs, rooms list appears empty.

We think it's a race condition and this onsucces[1] is not fired.

[1] https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/app/js/helpers/rooms_db.js#L154
Assignee: nobody → frsela
Blocks: 1097722
Assignee: frsela → crdlc
Attached file Github pull request (obsolete) — 

        Attachment #8533663 -
        Flags: review?(frsela)
Status: NEW → ASSIGNED
Assignee: crdlc → frsela

        Attachment #8533663 -
        Flags: review?(frsela) → review-

    
    

    
  

      
      
      
      

        Attached file
          
        Proposed patch
        — 
      

    


  

        Attachment #8534289 -
        Flags: feedback?(crdlc)

    
    

    
  
Comment on attachment 8534289 [details] [review]
Proposed patch

Don't forget to use this new cursor for all getAlls and for Events

        Attachment #8534289 -
        Flags: feedback?(crdlc) → feedback+

    
    

    
  
Comment on attachment 8534289 [details] [review]
Proposed patch

Refactored

        Attachment #8534289 -
        Flags: review?(crdlc)

        Attachment #8533663 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8534289 [details] [review]
Proposed patch

LGTM, thanks a lot. Left two comments but minor

        Attachment #8534289 -
        Flags: review?(crdlc) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/dadae2f04366d4701632cccf5bef2ad5835cbb2d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        Race condition fix
        — 
      

    


  

        Attachment #8534988 -
        Flags: review?(crdlc)

        Attachment #8534988 -
        Flags: review?(crdlc) → review?(borja.bugzilla)

    
    

    
  
Comment on attachment 8534988 [details] [review]
Race condition fix

r+, thanks

        Attachment #8534988 -
        Flags: review?(borja.bugzilla) → review+

    
    

    
  
Landed race condition fix: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/98f18c18393f6e220a33d5b1950b70a380bd20a8
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

    
    

    
  

      
      
      
      

        Attached file
          
        Github pull request
        — 
      

    


  

        Attachment #8535028 -
        Flags: review?(frsela)

    
    

    
  
Comment on attachment 8535028 [details] [review]
Github pull request

LGTM

        Attachment #8535028 -
        Flags: review?(frsela) → review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: