1109032 - [Loop] Can't open only audio call from received shared link.

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Javier de Prado]

ENV:
v1.1, v 4212078
FireE comercial build.

STR:
1.- Open received shared link (vía sms or email) on FireE.
2.- Once browser is opened, select "Voice conversation" option.

ACTUAL RESULT: Loop app is opened, and outgoing Video conversation is established.

EXPECTED RESULT: outgoing audio conversation should be established.

Comment 1

[Maria Angeles Oteo (:oteo)]

I am missing some steps... why should we start an audio conversation call?

Comment 2

[Javier de Prado]

From Browser you can open video call by default (green button, with text "start" and cam icon), or clicking on the small arrow pointing down, you can choose "Voice conversation" option.
Even having audio call by default in loop app settings, video call is opened from the mobile browser.

Comment 3

[Maria Angeles Oteo (:oteo)]

After checking that sharing an URL between two desktops, when browser is opened and "Voice conversation" is selected, is working fine and an outgoing audio conversation is launched we suspect that the fault is in the Loop  mobile client.

It seems that we are not checking the callType value in the LOOP_CALL activity sent from the Standalone UI, and that's the reason we are not setting correctly this variable.

Apart from that, and after including some logs, we are seeing that the callType sent from the Standalone UI is "undefined" so we are not sure if the Standalone UI is working as expected either, Carmen could you be so kind of checking this? and please, let's know if we need to open a standalone bug if it's necessary, thanks a lot!

Comment 4

[Carmen Jimenez Cabezas]

Attachment: V1 proposed patch

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8535796 [details] [diff] [review]
V1  proposed patch

Review of attachment 8535796 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/standalone/content/js/webapp.jsx
@@ +153,5 @@
>  
>    var FxOSConversationModel = Backbone.Model.extend({
> +    setupOutgoingCall: function(selectedCallType) {
> +      if (selectedCallType) {
> +       this.set("selectedCallType", selectedCallType);

nit: two-space indent please, although I think you could simplify this not to save the selectedCallType, unless there's a specific reason that the FxOSConversationModel needs it.

Comment 6

[Carmen Jimenez Cabezas]

Attachment: V2 proposed patch

r = standard8

Comment 7

[Carmen Jimenez Cabezas]

(In reply to Mark Banner (:standard8) from comment #5)

> nit: two-space indent please, although I think you could simplify this not
> to save the selectedCallType, unless there's a specific reason that the
> FxOSConversationModel needs it.

 I need to save the state because when the app it's not installed this will be called twice (one directly and one after the app is installed). On the second call we don't have that available anymore, and so it's recovered from the object state.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is there a Try link for this? :)

Comment 9

[Carmen Jimenez Cabezas]

Sorry!, try:
https://tbpl.mozilla.org/?tree=Try&rev=0674448d2e9f

Comment 10

[Maria Angeles Oteo (:oteo)]

Please, we need it for Fx35

Comment 11

[Maire Reavy [:mreavy]]

This is standalone -- so it just needs to land and merge in m-c this week (which is officially the Fx37 cycle), and it will be in the next release of the standalone app.  We are planning to do another standalone release before Fx35 goes to release (Jan 13).  How soon do you need the standalone updated?

Comment 12

[Maria Angeles Oteo (:oteo)]

Can you confirm it will be in the Standalone UI Dev Client as soon as it's merged in m-c?

Obviously, we would like to test it in production as soon as we can, if it's not possible to do it before the end-of-year at, least it would be great to have it by 7th January.

Comment 13

[Carmen Jimenez Cabezas]

treeherder looks ok
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0674448d2e9f
Requesting checkin

Comment 14

[Maire Reavy [:mreavy]]

(In reply to Maria Angeles Oteo (:oteo) from comment #12)
> Can you confirm it will be in the Standalone UI Dev Client as soon as it's
> merged in m-c?

You can test it on the dev server basically as soon as the code merges to m-c.  You'll know when that happens if you hang out in #loop.  (The system posts to #loop when the standalone code on the dev server is updated.)  

> Obviously, we would like to test it in production as soon as we can, if it's
> not possible to do it before the end-of-year at, least it would be great to
> have it by 7th January.

Let me talk with Mark (Standard8) and the server folks to see if we can update the standalone product on Jan 6.  Standalone updates can roll out in less than a day.  (The last one took only 2-3 hours.)  Doing a needinfo to Mark so this request (to roll out a new standalone on or before Jan 7) is on his radar and so I don't forget to discuss this with him today.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/353443a10c4b

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/353443a10c4b

Comment 17

[Maria Angeles Oteo (:oteo)]

Thanks a lot Maire!

Comment 18

[Maire Reavy [:mreavy]]

This has landed, and we're planning to push a new standalone app on or before Jan 7.  So I'm clearing the needinfo to Mark.