1109065 - Talk bubbles should be aligned based on UX doc

Status: RESOLVED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Schalk Neethling [:espressive]]

Currently bubbles are displayed aligned left always. This needs to change based on UX doc also, helpee's will not have avatars.

https://mozilla.app.box.com/s/iuv22j4jo3iwrkgr3srt

Comment 1

[Schalk Neethling [:espressive]]

Attachment: https://github.com/mozilla/buddyup/pull/47

Comment 2

[Anthony Ricaud (:rik)]

Comment on attachment 8543879 [details] [review]
https://github.com/mozilla/buddyup/pull/47

In submit_comment(), we also need to add the 'class="helper-comment' to the <li> we generate.

Otherwise, this is good.

Comment 3

[Schalk Neethling [:espressive]]

I looked at the code and there are a couple of things I need to take care of in order to finish it up.

Currently the class on the list item is set it thread.html and when a user makes a comment, that is not touched, only comment.html is so, I need to amend thread.html or get rid of it and use another approach.

Secondly, I do not have access to the question object, but I do the id, so I need to get the question in order to know whether the new comment is from a helper or, from the original author of the question i.e. the helpee

I will work on this tomorrow, or at the latest Monday.

Anthony, if you have another idea on how this can be resolved, let me know.

Comment 4

[Anthony Ricaud (:rik)]

I went ahead and fixed this. I've rebased the commit on master too. We can refactor in another bug maybe but I wanted to close this.

https://github.com/mozilla/buddyup/commit/9a4311e8e61ec96643dbc29af1ff472f96338524